Open
Conversation
Be-ing
commented
Dec 11, 2022
| } | ||
|
|
||
| // TODO: fix macro | ||
| // iterators!(range: core::ops::Range<usize> => self.range(range.clone(()); |
Contributor
Author
There was a problem hiding this comment.
If you can suggest how to get the macro to accept the range.clone(), that would allow getting rid of the boilerplate below.
Be-ing
commented
Dec 11, 2022
Comment on lines
+370
to
+374
| fn range(self, range: impl core::ops::RangeBounds<usize>) -> Self { | ||
| // Hack around trait method taking `self` rather than `mut self`. | ||
| // This method returns a Self by value, so it is okay to move self | ||
| // into a mut variable. | ||
| let mut new = self; |
Contributor
Author
There was a problem hiding this comment.
Alternatively the trait method could take mut self, but I wanted to keep the signature consistent with the skip/tail/limit methods.
Contributor
Author
|
Rubato uses slice ranges a lot, so this is very helpful for refactoring Rubato. |
udoprog
changed the title
Owner
|
Rebased by cherry-picking the |
Contributor
Author
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on top of #13 because I'm tired of rebasing