Conversation
|
I can also see an instance where we remove the different flavor components as well and let the integrator add them in as required. Not every package will have 3 flavors, plus I could see it cutting down on noise for a newer integrator. |
|
Commented out code without clear indicators that it is meant to serve as documentation to me reads as cruft or WIPs. Which is not a decision that is helpful to put on the consumers. Given that this is a template repo having links in the README that points back to the docs and working examples would be a good replacement IMO. That said, I am in favor of deleting if it feels like noise to you. |
| # Copyright 2024 Defense Unicorns | ||
| # SPDX-License-Identifier: AGPL-3.0-or-later OR LicenseRef-Defense-Unicorns-Commercial | ||
|
|
||
| # variables: |
There was a problem hiding this comment.
can we add some variable to reference-package's uds-config.yaml to serve as an example instead of this?
There was a problem hiding this comment.
what if the README links to the reference-package and dev's could reference those files as needed?
|
for me, when working on a package from template, the amount of things was overwhelming at first. I'm wondering if adding things - like the variables example, and other examplish things that are getting rightfully removed from the template, aren't worth adding to the reference-package. |
@michalszynkiewicz, I feel that most of, if not all of the things being removed here are already exemplified in the |
I had similar thoughts, especially with an example of multiple flavors in the reference-package. The downside I can see is confusion on the standard for when a Unicorn creates a new package. My vote:
|
|
Some items for consideration:
|
Description
template. Would like feedback on much of these changes.noise, IMO. I can be convinced to add things back in that show value, but I feel most of these values get delete anyway by the package integrator.Still to do:
CODEOWNERS-template.mdandREADME-template.mdand replace with some documentation in thedocsfolder.