Skip to content

fix release workflow trigger#14

Merged
fqjony merged 1 commit into
mainfrom
fix/release-workflow
Apr 14, 2026
Merged

fix release workflow trigger#14
fqjony merged 1 commit into
mainfrom
fix/release-workflow

Conversation

@fqjony

@fqjony fqjony commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove branch filter from release workflow — the reusable workflow gates on release_branch internally (matches udx/worker-deployment pattern)
  • Add workflow_dispatch for manual re-triggers

Previous runs failed with ENEEDAUTH because re-runs inherited stale permissions from before the GitHub environment was created. A fresh push to main will pick up the correct id-token: write permission.

Test plan

  • Merge triggers fresh release run with OIDC npm publish

🤖 Generated with Claude Code

Remove branch filter — the reusable workflow gates on release_branch
internally. Add workflow_dispatch for manual triggers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 14, 2026 16:54
@fqjony fqjony requested a review from udx-github April 14, 2026 16:54
@fqjony fqjony self-assigned this Apr 14, 2026
@fqjony fqjony merged commit c90ec0f into main Apr 14, 2026
12 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the npm release GitHub Actions workflow triggers so releases can be re-run manually and are no longer limited by a main branch filter (relying on the reusable workflow’s internal release_branch gating).

Changes:

  • Removed the push.branches: [main] filter so the workflow triggers on any push.
  • Added workflow_dispatch to allow manual runs/re-triggers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -2,7 +2,7 @@ name: Release

on:
push:

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on: push: is currently configured with a null/empty value. While GitHub Actions often treats this like an unfiltered push trigger, it’s ambiguous and easy to misread. Consider making it explicit (e.g., push: {} or using the short form on: [push, workflow_dispatch]) to avoid YAML/Actions parsing surprises and improve clarity.

Suggested change
push:
push: {}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants