Open
Conversation
if writes to a json failed the program just crashed before, with this it retries 3 times with 200ms between try's
before it would send one per number of pilots, sometimes with missing pilots, this makes working with the data in external programs much simpler.
Owner
|
Hi TuxRich! We've actually already got a retry on db fail in JSON IO which all writes/reads go through anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Missing Results on refresh
I have added a retry for DB writes, we had a few crashes at BIRD when Trackside failed to write the file and it crashed in the middle of a race, I have only once manged to reproduce this once on my dev laptop so I think its very hardware dependent, it now try's 3 times and logs instead of crashing.
Remote Notifier: Wait for all pilots then send one notification with all pilots
before it would send one per pilot in the race, sometimes with missing pilots, this makes working with the data in external programs much simpler.