Add Anthropogenic Emissions#215
Merged
clark-evans merged 8 commits intoufs-community:gsl/developfrom Mar 26, 2026
Merged
Conversation
mdtoyNOAA
approved these changes
Mar 4, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
clark-evans
reviewed
Mar 13, 2026
joeolson42
reviewed
Mar 13, 2026
joeolson42
reviewed
Mar 13, 2026
joeolson42
reviewed
Mar 13, 2026
joeolson42
approved these changes
Mar 13, 2026
Collaborator
joeolson42
left a comment
joeolson42
left a comment
There was a problem hiding this comment.
conditional approval dependent upon some contemplation of my suggestions.
clark-evans
approved these changes
Mar 13, 2026
Collaborator
clark-evans
left a comment
clark-evans
left a comment
There was a problem hiding this comment.
OK with me once the formatting comments (and Joe's comments) are addressed. I'd recommend we wait to merge this until after #218 so that we can have those tests run on this PR.
Collaborator
Author
Sure, thanks! This PR has been updated to address the comments and suggestions from you and Joe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new tracer, unspc_fine, representing fine anthropogenic primary aerosols. The registry.chemistry.xml file has also been reorganized to support this update.
This enhancement is expected to improve PM2.5 forecasts by better representing anthropogenic emission contributions. It will also be a key component of aerosol emissions in cloud physics processes (in our next PR).
Priority Reviewers