Add two new namelist options to control the hydrometeors to be included in the LBC files.#234
Conversation
|
Thanks for this PR, @hu5970. Could you please update the indentation to match that from the existing Registry entries? Here on Github, it looks like many of the indents are one tab too short. I think this can occur with using tabs vs. spaces for indentation; I believe the MPAS default is spaces. |
to be included in the LBC files. This is because the resource model has different hydrometeors in their products. The two options added are for the LBC from GFS or GEFS.
hu5970
force-pushed
the
bdy_package_control
branch
from
e491b70 to
93d0ad5
Compare
|
@clark-evans Thank you for pointing this out. I have made the necessary changes to align the new entry with the existing Registry entries. |
|
@clark-evans Should I do something to move this PR forward. Thanks, Ming |
We have a code discussion this afternoon. This will be at the top of the agenda. I expect we can merge it later today. We need to get #233 merged first, but I'm awaiting one final change from @dustinswales before we can do so. |
A couple of these are for the new code, others are for previously added code by GSL/NSSL
|
Hi @hu5970 -- would you be willing to change 'tempoall' to 'hrrr' or 'rrfs' (or similar) for consistency with 'gfs'? We feel that a consistent naming convention for these new namelist options would be preferable. Otherwise, this should be good to go. Note that we did update the PR yesterday with the top of gsl/develop, which allows all of the CI tests to pass, and some additional Registry formatting cleanup. Thus, if you could work from the updated PR, it'd be much appreciated. Thanks, and let me know if you have any questions. |
|
@clark-evans I will try to change the 'tempoall' to 'rrfs' today. Thanks, Ming |
…mpoall' to 'rrfs' for consistency with 'gfs'
|
@hu5970 It is great that this PR gets merged. However, we are not able to use this version directly in rrfs-workflow since both the flexible output and output_done_marker capabilities have already been integrated in the workflow. We will need to port the change in this PR to RRFSx/MPAS-Model through a new PR. Do you have time to do that? If not, I can help with it. Thanks! |
|
@guoqing-noaa can you submit a PR here with the output_done_marker capabilities? @SamuelTrahanNOAA is reviewing the flexible output PR again to help move it along. |
@clark-evans @SamuelTrahanNOAA Thanks a lot! The output_done_marker change is ready but it depends on one of the function added in PR #217. So it may be better to create that PR here after PR #217. A sneak peak of what that change looks like: https://github.com/RRFSx/MPAS-Model/pull/20/changes |
… to be included in the LBC files. (ufs-community#234) * Add two new namelist options and packages to control the hydrometeors to be included in the LBC files. This is because the resource model has different hydrometeors in their products. The two options added are for the LBC from GFS or GEFS. * Updating tabs to spaces for selected registry elements * In core_init_atmosphere/Registry.xml, change bdy option name from 'tempoall' to 'rrfs' for consistency with 'gfs' * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov>
* v8.3.1-2.13: Update MPAS HRRR CI test for tempo v3 lookup tables (ufs-community#213) * Update MPAS HRRR CI test for tempo v3 lookup tables * Update version in README * v8.3.1-2.14: TEMPO code cleanup and refactor for v3.0.0 and MPAS release (ufs-community#192) * removed unused configuration variable - added graupel volume to init_atmosphere registry - formatted code * cleaned up core_atmosphere registry for tempo * cleaned up mpas tempo driver call and removed tempo table build from mpas * v3.0.0 updates consistent with tempo refactor * v3.0.0 tempo refactor with ml prediction for bl clouds * update point to tempo v3 and clean up code to better match NCAR implementation * Update CMakeList for tempo v3 * add compile option for tempo * More updates to github runners for tempo v3 * change workflow to pull tempo v2 and v3 tables * adds flag to turn on/off ability to calculate reflectivity from melting snow/graupel * update pointer to tempo v3.0.2 * update to version 3.0.3 with more ccpp changes * Update version number in README --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * update to joes mynn * Updating version number * v8.3.1-2.16: Adding MYNN-SFC submodule to MPAS (ufs-community#210) * submodularizing the MYNN surface layer scheme * bug fix in physics/Makefile * modified sfclayer and seaice driver for mynnsfc submodule * removing compilation of (my) old MYNN sfclayer scheme * added note in mpas_atmphys_vars.F that qcg is no longer needed in mynnsfc submodule * added config options for MYNN sfc layer submodule * bug fix for bringing in new flags for MYNN sfclayer submodule * Final bug fixes for MPAS compilation * Updating pointer to MYNN-SFC with a new debug Makefile for MPAS * bug fix for adding necessary input into the MYNN-SFC submodule * addressing cmake errors * Final update to MYNN-SFC pointer, which includes RUC-tuned option config_mynn_sfcflux_land =1 * changing default config_mynn_sfcflux_land from 0 to 1 * a few bug fixes in MYNN-SFC and corresponding driver changes * update pointer to MYNN-SFC, only formatting/cleanup * Update version number * fix typo --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * v8.3.1-2.17: Restructure GFL submodule for MPAS, WRF, and CCPP (ufs-community#211) * "Resture GFL submodule for MPAS, WRF, and CCPP" * "update GFL for CMake" * "turn off shallow convection for both bl_mynn and bl_mynnedmf" * Update version number * v8.3.1-2.18: hotfix to the build failure using `make -j8` with spack-stack (ufs-community#221) * core_mynnsfc and core_physics_noahmp need to depend on core_physics_init * bump version to 8.3.1-2.18 * Update PR template Added mandatory questions section to PR template. * Containerized CI + Cleanup testing (ufs-community#218) * Update CI * Update README.md --------- Co-authored-by: dustinswales <dswales@ucar.edu> * v8.3.1-2.20: Add mmm physics as submobule. (ufs-community#233) * Initial commit * CI trigger test * Address reviewer comment * Update README.md * v8.3.1-2.21: Add two new namelist options to control the hydrometeors to be included in the LBC files. (ufs-community#234) * Add two new namelist options and packages to control the hydrometeors to be included in the LBC files. This is because the resource model has different hydrometeors in their products. The two options added are for the LBC from GFS or GEFS. * Updating tabs to spaces for selected registry elements * In core_init_atmosphere/Registry.xml, change bdy option name from 'tempoall' to 'rrfs' for consistency with 'gfs' * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * v8.3.1-2.22: restore extra spaces in mpas_stream_manager.F to match NCAR's version (ufs-community#238) * restore extra spaces in mpas_stream_manager.F to match NCAR's version * Update version number --------- Co-authored-by: Clark Evans <clark.evans@noaa.gov> * final updates to match --------- Co-authored-by: AndersJensen-NOAA <132939212+AndersJensen-NOAA@users.noreply.github.com> Co-authored-by: Clark Evans <clark.evans@noaa.gov> Co-authored-by: Joseph Olson <joeolson42@users.noreply.github.com> Co-authored-by: haiqinli <38666296+haiqinli@users.noreply.github.com> Co-authored-by: Guoqing Ge <guoqing.ge@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: dustinswales <dswales@ucar.edu> Co-authored-by: Ming Hu <Ming.Hu@noaa.gov>
3 participants
This PR is to generate the hydrometeors included in the LBC files based on the boundary resource model products because the different resource model provides different hydrometeors.
The method used here is based on an example provided by Michael Duda: see the commit in his branch (https://github.com/mgduda/MPAS-Model/commits/init_atmosphere/lbc_scalar_packages/). The commit message give a clear description of how the package is controlled by a namelist option and attached to hydrometeor species,. What's nice about this approach is that there is no code to be written -- only changes to the Registry.xml file are needed.
The two options with default values are:
config_lbc_hydrometeors_tempoall = true
config_lbc_hydrometeors_gfs = false
for the LBC from GFS, set:
config_lbc_hydrometeors_tempoall = false
config_lbc_hydrometeors_gfs = true
for the LBC from GEFS, set:
config_lbc_hydrometeors_tempoall = false
config_lbc_hydrometeors_gfs = false
The test was conducted with CONUS 3km RRFSv2X case and the reduced size boundary files can produce the same results as original large boundary files if they are generated from the same resource model products.
Mandatory Questions