Support for Angular v21 and a bug fix! by lindolo25 · Pull Request #1012 · ui-router/angular

lindolo25 · 2025-12-12T00:59:46Z

Hi @wawyed! This PR implements support for v21 and fixes a recent bug I notice, specific for zoneless apps. I decided to add these changes together to take the least of your time. If instead you will like for me to treat it as 2 separate changes, I'll be happy to split the changes and create merge request individually.

More about the changes:

Angular v21 support.
Added downstream test projects for zoneless applications.
Changes to UIView that introcudes @if as replacement for *ngIf directive (currently deprecated) and signals specifically for the _componentRef property of the class.
Added test suites that for the specific scenario of the bug. It involved add test environments configured to use zoneless.

About the bug: It is only reproducable for applications configure with zoneless change detection or for UIView's instances hosted by a component configured with change detection strategy onPush. It involves the projected content of UIViews. here is an example of the components configuration.

@Component({
  selector: 'app-root',
  imports: [UIView, AnchorUISref, UISref],
  changeDetection: ChangeDetectionStrategy.OnPush,
  template: `
    <h1>Hello from {{ name }}!</h1>
    <ui-view>
      <a uiSref="root.child">follow this link to open the child state</a>
    </ui-view>
  `,
})
export class AppComponent {
  name = 'UIView Zoneless bug demo';
}

@Component({
  selector: 'app-child',
  imports: [UISref, AnchorUISref],
  changeDetection: ChangeDetectionStrategy.OnPush,
  template: `
    <a uiSref="^">Use this link to go back</a>
    <p>Use the browser's back button to reproduce the bug.</p>
  `,
})
export class AppChildComponent {}

export const routes: Ng2StateDeclaration[] = [
  {
    name: 'root',
    url: '/home',
    component: AppComponent,
  },
  {
    name: 'root.child',
    url: '/child',
    component: AppChildComponent,
  },
];

bootstrapApplication(UIView, {
  providers: [
    provideZonelessChangeDetection(),
    provideUIRouter({
      states: routes,
      otherwise: '/home',
    }),
  ],
});

Steps to reproduce:

use the link in the /home page to navigate to the child state. the AppChildComponent will replace the content for UIView.
use the link in the /child page to go back to /home. All works fine so far, the projected content for the UIView is restored.
use the browser's back button to go back. The projected content is not restored.

Here are a few links to working examples of this bug:

zoneless: https://stackblitz.com/edit/stackblitz-starters-uonxgsrb
change detection onPush: https://stackblitz.com/edit/stackblitz-starters-czh5sqlm

Another topic:

The merge request for sample-app-angular that added support for v20 was never merge. I'll be adding a new PR with support for v21. ui-router/sample-app-angular#795

Fixes #1010

versions for other packages as needed for peer dependency requirements

…update to the angular's v21

v21. this needs to be done in a separeted step as the cli requires for the git chnages to be cleared before updating packages.

_componentRef to be a readonly signal and updating ChangeDetectionStrategy to onPush. This fixes issue restoring the projected content when navigating from a child state to a state with projected content.

navigating back form a chils state.

the global test to run both zone and zoneless test suites.

zoneless aplications.

lindolo25 · 2026-01-02T15:06:08Z

Hi @wawyed and @christopherthielen, I updated this PR with the recent changes to main, it is ready for review. thanks again for your time and Happy new year!

christopherthielen · 2026-01-03T22:32:30Z

I'll take a look, thanks for the PR!

Note: I'm not longer using or tracking the Angular project, but I've been updating a bunch of other ui-router packages recently, trying to modernize and consolidate tooling.

Copilot

Pull request overview

This PR adds Angular v21 support and fixes a bug affecting projected content restoration in UIView components when using zoneless change detection or OnPush change detection strategy. The fix replaces the deprecated *ngIf directive with Angular's @if control flow and converts _componentRef to a signal to ensure proper change detection.

Key changes:

Upgraded to Angular v21 and TypeScript 5.9 across all test projects and dependencies
Fixed UIView projected content restoration bug by converting _componentRef to a signal and using @if instead of *ngIf
Added comprehensive test coverage for zoneless applications including new test suites and downstream projects

Reviewed changes

Copilot reviewed 43 out of 76 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/directives/uiView.ts	Fixed bug by converting `_componentRef` to signal and replacing `*ngIf` with `@if`
test/uiView/viewIsRestored.spec.ts	Added test suite for projected content restoration
test-zoneless/uiView/viewIsRestored.spec.ts	Added zoneless-specific test suite for the bug fix
test-zoneless/setupJest.ts	Setup for zoneless test environment
test-zoneless/tsconfig.spec.json	TypeScript config for zoneless tests
package.json	Updated dependencies to Angular v21 and split test scripts
test-angular-versions/v21/*	New test project for Angular v21
test-angular-versions/v21-zoneless/*	New test project for Angular v21 zoneless
test-angular-versions/v21-standalone/*	Updated standalone test project to v21
test-typescript-versions/typescript5.9/*	Added TypeScript 5.9 test project
downstream_projects.json	Updated downstream project references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-03T22:34:58Z

test/uiView/viewIsRestored.spec.ts

+      expect(h2Elelement).toBeFalsy();
+    });
+
+    it("should the child component", async () => {


Corrected test description from 'should the child component' to 'should show the child component'.

Suggested change

it("should the child component", async () => {

it("should show the child component", async () => {

Copilot · 2026-01-03T22:34:59Z

test-zoneless/uiView/viewIsRestored.spec.ts

+      expect(h2Elelement).toBeFalsy();
+    });
+
+    it("should the child component", async () => {


Corrected test description from 'should the child component' to 'should show the child component'.

Suggested change

it("should the child component", async () => {

it("should show the child component", async () => {

Copilot · 2026-01-03T22:34:59Z

test-angular-versions/v21-zoneless/README.md

@@ -0,0 +1,27 @@
+# v21-zoneless
+
+This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 20.0.5.


The README states the project was generated with Angular CLI version 20.0.5, but this is a v21-zoneless project. Update the version number to match the project version (e.g., 21.0.2 based on package.json).

Suggested change

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 20.0.5.

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 21.0.2.

Copilot · 2026-01-03T22:34:59Z

test-angular-versions/v21-standalone/README.md

-# V20-standalone
+# V21-standalone

 This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 20.0.5.


The README states the project was generated with Angular CLI version 20.0.5, but this is a v21-standalone project. Update the version number to match the project version (e.g., 21.0.2 based on package.json).

Suggested change

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 20.0.5.

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 21.0.2.

christopherthielen · 2026-01-03T23:03:46Z

Well, this all looks great and I see no blockers. @wawyed I'm going to merge this and start the release process

christopherthielen · 2026-01-04T07:26:46Z

@lindolo25 @wawyed please try this when you can and report any problems

lindolo25 · 2026-01-04T15:50:41Z

Hi @christopherthielen, thanks for the help with this PR.

I'll take a look, thanks for the PR!

Note: I'm not longer using or tracking the Angular project, but I've been updating a bunch of other ui-router packages recently, trying to modernize and consolidate tooling.

If you like any help, let me know! I also wanted to ask if it is possible for the documentation to be updated for https://ui-router.github.io. I look at the build process as configured in several of the projects and I think there was an error with the typescript version being incompatible in the Docs container image and the angular project. I can take a look again and create a PR!

christopherthielen · 2026-01-05T21:33:40Z

The docgen system seems rather broken at the moment. If you can get it working again, that would be awesome.

I do have a dream to modernize all the depts of the whole ui router ecosystem and then converge everything into a monorepo. At that point it would be worth looking into different docs paradigm.

That's a lot though, and may never happen. So if we can resurrect the existing docgen, it would be very useful.

lindolo25 · 2026-01-14T18:44:31Z

Hi @christopherthielen, I wanted to update you on some of the troubleshooting I've been doing for the Docs. Indeed the first problem is Typescript compatibility between projects. So far I tested a few changes for projects to make the build work:

publish-scripts: Updated the dockerfile to use node v22 and package.json to use typescript v5.9 and typedoc v0.28.
typedoc-plugin-ui-router: updated typedoc to v0.28, and made changes to the implementation of the plugin due to changes in the API.

None of the changes I have are final, that's why I haven't created any pull request. But with them, the docs script of this project builds. Styling is broken and I still have to find out how this build fits with the rest of the projects for the publish. I'll let you know more as I progress!

lindolo25 added 15 commits December 8, 2025 11:42

Update Angular packages to v21. This commit also updates minor/mayor

67a673b

versions for other packages as needed for peer dependency requirements

Update to compiler options for tests, this fixes failing tests after …

1528733

…update to the angular's v21

Update downstream test porject for typescript to version 5.9

882fd83

Replace downstream test project for standalone angular v20 with a v21

2cbb420

update angular version for downstream project v21-standalone from v20 to

1c63f39

v21. this needs to be done in a separeted step as the cli requires for the git chnages to be cleared before updating packages.

Replace downstream test project for v20 to v21.

ff3c9d3

Update donwstream_projects file, Angular tests are now v21.

c1d8012

replace *ngIf with @if for UIView component. it includes transforming

a647147

_componentRef to be a readonly signal and updating ChangeDetectionStrategy to onPush. This fixes issue restoring the projected content when navigating from a child state to a state with projected content.

New test cases to confirm projected content is restored for UIView when

6419ccb

navigating back form a chils state.

New tests suites for zoneless specific scenarios related to UIView.

3cfdffe

Update to configuration for scripts. added tests fo zoneless and update

b73d2e0

the global test to run both zone and zoneless test suites.

Create zoneless downstream project to test for any regressions with

9763afb

zoneless aplications.

reverting the addition of change detection onPush for UIView component.

2ca4491

Merge remote-tracking branch 'upstream/master' into chore/ng-v21-support

1a23597

Bump uirouter/core peer dependency to v6.1.2

74d7e35

christopherthielen requested a review from Copilot January 3, 2026 22:34

Copilot AI reviewed Jan 3, 2026

View reviewed changes

christopherthielen merged commit c005e01 into ui-router:master Jan 3, 2026
4 checks passed

christopherthielen added a commit that referenced this pull request Jan 3, 2026

fix: support zoneless (#1012)

6fa2d1e

medi6 mentioned this pull request Jan 6, 2026

v21 regression : component is loaded twice #1017

Open

sbschorer mentioned this pull request Jan 28, 2026

Support for angular 21 it will be release ? #1026

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Angular v21 and a bug fix!#1012

Support for Angular v21 and a bug fix!#1012
christopherthielen merged 15 commits intoui-router:masterfrom
lindolo25:chore/ng-v21-support

lindolo25 commented Dec 12, 2025 •

edited

Loading

Uh oh!

lindolo25 commented Jan 2, 2026

Uh oh!

christopherthielen commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

christopherthielen commented Jan 3, 2026

Uh oh!

Uh oh!

christopherthielen commented Jan 4, 2026

Uh oh!

lindolo25 commented Jan 4, 2026

Uh oh!

christopherthielen commented Jan 5, 2026

Uh oh!

lindolo25 commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	it("should the child component", async () => {
	it("should show the child component", async () => {

		@@ -0,0 +1,27 @@
		# v21-zoneless

		This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 20.0.5.

Conversation

lindolo25 commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lindolo25 commented Jan 2, 2026

Uh oh!

christopherthielen commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

christopherthielen commented Jan 3, 2026

Uh oh!

Uh oh!

christopherthielen commented Jan 4, 2026

Uh oh!

lindolo25 commented Jan 4, 2026

Uh oh!

christopherthielen commented Jan 5, 2026

Uh oh!

lindolo25 commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lindolo25 commented Dec 12, 2025 •

edited

Loading