Update uisref on param changing, not only state#976
Open
oBusk wants to merge 2 commits intoui-router:masterfrom
Open
Update uisref on param changing, not only state#976oBusk wants to merge 2 commits intoui-router:masterfrom
oBusk wants to merge 2 commits intoui-router:masterfrom
Conversation
wawyed
reviewed
Jan 14, 2023
src/directives/uiSref.ts
Outdated
| this._parent = parent; | ||
|
|
||
| this._statesSub = _router.globals.states$.subscribe(() => this.update()); | ||
| this._statesSub = _router.globals.params$.subscribe(() => this.update()); |
Member
There was a problem hiding this comment.
I'm guessing this was supposed to be _paramsSub
Contributor
Author
There was a problem hiding this comment.
That was definitely my intention 😅 Fixed it! (0ebf4c1)
Contributor
Author
|
@wawyed When I looked at the code to fix the typo got me thinking if it's unecessary to update the sref twice in the scenario where you switch state and params? Maybe it'd work better if we were to listen to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a link where some of the params are inherited, they will become outdated if the params change without the state changing.