-
Notifications
You must be signed in to change notification settings - Fork 17
💨 ♻️ Create Vacuum Vessel class #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
==========================================
- Coverage 46.29% 46.27% -0.02%
==========================================
Files 123 123
Lines 28841 28869 +28
==========================================
+ Hits 13351 13360 +9
- Misses 15490 15509 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c30853a to
ad32540
Compare
ad32540 to
790a52c
Compare
c3a8019 to
7869c1a
Compare
7869c1a to
5791a40
Compare
5791a40 to
4c8f2d7
Compare
… tests for elliptical vessel volumes
j-a-foster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with transfer of code.
This pull request refactors the calculation and management of vacuum vessel geometry and volumes, moving these responsibilities out of the
blanket_libraryand into a new dedicatedVacuumVesselclass. The vacuum vessel logic is now encapsulated and run independently, leading to a cleaner separation of concerns and easier maintenance. Related test code and obsolete code paths have also been updated or removed to match the new structure.Refactoring and Encapsulation of Vacuum Vessel Calculations:
Introduced a new
VacuumVesselclass inprocess/vacuum.pythat handles all vacuum vessel geometry and volume calculations, including methods for D-shaped and elliptical vessel geometries, and applies the vessel coverage factor and density calculation. The vacuum vessel logic is now invoked viaself.models.vacuum_vessel.run()in the main model runner.Removed all vacuum vessel-related calculations from
blanket_library.py, including volume and half-height computations, as well as code that previously handled the vacuum vessel as a third component (icomponent==2). The blanket and shield calculations now only consider two components.Test Code Updates:
test_blanket_library.pythat referenced vacuum vessel geometry or volumes, since these are now handled by the newVacuumVesselclass and are no longer part of the blanket library interface.Other Code Cleanups:
hcpb.py, as this is now handled in the new class.This refactor improves code maintainability by isolating vacuum vessel logic, reducing coupling between the blanket library and vessel calculations, and ensuring that each component is responsible for its own domain.## Description
Checklist
I confirm that I have completed the following checks: