Skip to content

Remove dead goreleaser release.header now that workflow composes the body#20

Merged
foadshafighi merged 1 commit intomainfrom
chore/clean-up-goreleaser-config
Apr 28, 2026
Merged

Remove dead goreleaser release.header now that workflow composes the body#20
foadshafighi merged 1 commit intomainfrom
chore/clean-up-goreleaser-config

Conversation

@foadshafighi
Copy link
Copy Markdown
Contributor

@foadshafighi foadshafighi commented Apr 28, 2026

Summary

Cleanup PR following the v0.5.1 smoke test. The release.header block in tools/validator/.goreleaser.yaml was duplicating header text that the workflow now composes into the release body explicitly (PR #19). Removing it eliminates the drift risk.

changelog: disable: true stays — it still does useful work (skips goreleaser's auto-commit-list generation, which would otherwise be wasted compute since our workflow overrides the body anyway). The comment above it is updated to reflect the new architecture.

Test plan

  • YAML valid
  • goreleaser check passes locally
  • CI passes
  • Validated end-to-end on the next release (v0.5.2 or v0.6.0)

Callouts for reviewers

  1. No behavior change for end users. The workflow's gh release edit step has been the source of the visible release body since PR Compose release body locally and set via gh release edit #19; goreleaser's release.header was already overridden.
  2. Comment refreshed to point at the workflow as the source of truth for the release body.

Greptile Summary

Removes the release.header block from tools/validator/.goreleaser.yaml that was already overridden by the gh release edit step added in PR #19, and updates the comment above changelog: disable: true to point at the workflow as the source of truth. Pure housekeeping with no behavioral impact.

Confidence Score: 5/5

Safe to merge — dead config removed, no logic or schema changes.

Single-file change that deletes unreachable config and refreshes a comment. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
tools/validator/.goreleaser.yaml Removes the release.header block that was overridden by the workflow anyway, and refreshes the changelog comment to point at the workflow as the source of truth. No semantic change.

Reviews (1): Last reviewed commit: "Remove dead goreleaser release.header no..." | Re-trigger Greptile

@foadshafighi foadshafighi requested a review from a team as a code owner April 28, 2026 00:23
@foadshafighi foadshafighi merged commit 6eb8eda into main Apr 28, 2026
4 checks passed
@foadshafighi foadshafighi deleted the chore/clean-up-goreleaser-config branch April 28, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant