packaging: fix Homebrew formula audit (dep order + resource name)#3
Conversation
The brew-bump release job copies packaging/distribution/autosentry.rb to the tap and rewrites url/sha256, so any FormulaAudit issue in this template re-breaks the tap's `brew test-bot --only-tap-syntax` on every release. The v0.7.4 bump did exactly that, reverting the tap's hand-fixes. Fix at the source: - autosentry.rb: order `rust` (build) before `python@3.13` (normal) per FormulaAudit/DependencyOrder; rename `resource "ruamel.yaml"` -> `"ruamel-yaml"` to match the normalized PyPI name. - gen_resources.py: emit PEP 503-normalized resource names (lowercase, [-_.]+ -> "-") so regeneration can't reintroduce names like "ruamel.yaml". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates Homebrew packaging by implementing PEP 503 resource name normalization in the generator and updating the formula accordingly. The generator now normalizes PyPI package names to canonical form, and the formula is adjusted to use the normalized ChangesResource name normalization and formula updates
Possibly related PRs
Poem
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Why
The release
brew-bumpjob copiespackaging/distribution/autosentry.rbinto the tap and rewrites onlyurl/sha256. So anyFormulaAuditissue in this template re-breaks the tap'sbrew test-bot --only-tap-syntaxon every release. The v0.7.4 bump did exactly that — it reverted hand-fixes that had been applied directly in the tap, turning the tap's CI red again:Fix (at the source, so it stops recurring)
autosentry.rb: orderrust(:build) beforepython@3.13(normal) perFormulaAudit/DependencyOrder; renameresource "ruamel.yaml"→"ruamel-yaml"to match the normalized PyPI name.gen_resources.py: emit PEP 503-normalized resource names (lowercase,[-_.]+→-), so a future regeneration can't reintroduce names likeruamel.yaml. URL/sha256 are unaffected.Validated:
ruby -c+py_compilepass.🤖 Generated with Claude Code
Summary by CodeRabbit