Add editable boat logfactor#173
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Implements #141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
logfactor(positive decimal) to capture a vessel-specific loch/log correction and allow sailors to edit and persist it from the boat form.Description
logfactor: numberto theBoatdomain model (app/models/boat.ts) and include it in theBoatFormtype (app/models/logbook-forms.ts).emptyBoat,defaultBoatForm, andboatToFormwith a fallback of1when loaded values are non-positive (app/components/logbook/forms.ts).Log factorin the boat manager form with required/positive validation and updatesaveBoatto persistboatForm.logfactorinto the savedBoatobject (app/components/logbook/pages/BoatManagerPage.tsx,app/components/LogbookApp.tsx).020_boat_logfactor.sql, updatingapp/lib/db/schema.sql, and extendingBoatsRepository.insertandLogSheetsRepository.toLogbookto read/write thelogfactor(app/lib/db/migrations/020_boat_logfactor.sql,app/lib/repositories/boats-repository.ts,app/lib/repositories/log-sheets-repository.ts).logfactorwhere required (app/lib/i18n/dictionaries/*,tests/*,tests/fixtures/logbook.ts).Testing
npm test(Vitest) and all test files passed:27test files,153tests passed and12skipped (final run succeeded).npm run typecheck(tsc --noEmit) and it succeeded with no type errors.npm run lint(eslint .) and it completed without errors.Codex Task