Implement logbook sharing#178
Open
ultimate wants to merge 8 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
private/registered/public) and fine-grained controls for which sections are visible (master data, picture, loglines, technical log, skipper, crew).Description
app/models/log-sheet.tsand extend stored row types inapp/models/logbook-rows.ts.app/lib/db/migrations/020_log_sheet_sharing.sqland updateapp/lib/db/schema.sql; wire the new columns into theLogSheetsRepositoryinsert and mapping logic (including boolean helpersboolValue/boolFromRow).app/lib/db/logbook-database.ts(readSharedSheet) and afilterSharedSheethelper to redact sections according to share settings.readSharedLogSheetinapp/lib/logbook-store.ts, add a JSON endpoint atapp/api/shared/logbooks/[sheetId]/route.ts, and a public UI atapp/share/[sheetId]/page.tsxto display shared sheets.LogbookDetailsPage.tsxandLogbookApp.tsx) withupdateActiveSheetShareto persist changes.tests/app/lib/repositories/log-sheets-repository.test.ts).Testing
npm run typecheckand the build passed successfully.npm run lintand no issues were reported.npm test(including targeted runs fortests/app/api/logbook-route.test.ts,tests/app/lib/repositories/log-sheets-repository.test.ts, andtests/app/lib/db/migrations.test.ts) and all tests passed.Codex Task