Fix wave training script imports#45
Conversation
|
👋 Hello @pderrenger, thank you for submitting a -✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
PR looks clean. The diff is limited to explicit import fixes, adding missing NumPy/Torch imports, and non-functional formatting/cleanup changes, and I did not find any genuine issues in the changed lines.
|
Merged — great cleanup work by @pderrenger, with contributions from @glenn-jocher. 🎉 As Leonardo da Vinci said, “Simplicity is the ultimate sophistication.” This PR reflects that well: clearer imports, safer dependencies, improved readability, and more consistent formatting all make Thanks for helping strengthen the codebase in ways that will benefit every future contributor. |
Summary
Tests
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🧹 This PR mainly cleans up and standardizes the
ultralytics/wavetraining scripts, improving code clarity, import safety, and maintainability without changing the core training behavior.📊 Key Changes
from utils import *→ targeted function importsfrom utils.torch_utils import *andfrom utils.utils import *→ explicit named importsnumpyandtorchwhere they were already being used.nz,nx, andymuto_nz,_nx, and_ymuto make it clear they are intentionally unused.f"{a!s}"andf"{i!s}".scipy.io.savemat(...)apply_gradients(...)splitdata()to return values across multiple lines for easier reading.🎯 Purpose & Impact