COCOS-DOCS-127 - Additional info on aTLS#128
Open
danko-miladinovic wants to merge 3 commits intoultravioletrs:mainfrom
Open
COCOS-DOCS-127 - Additional info on aTLS#128danko-miladinovic wants to merge 3 commits intoultravioletrs:mainfrom
danko-miladinovic wants to merge 3 commits intoultravioletrs:mainfrom
Conversation
SammyOina
reviewed
Dec 16, 2025
Contributor
SammyOina
left a comment
SammyOina
left a comment
There was a problem hiding this comment.
Add the possible attacks and how we mitigate against them
muhammad-usama-sardar
suggested changes
Jan 27, 2026
There was a problem hiding this comment.
reportdata is critical for specs.
How do protect against diversion attacks?
|
|
||
|  | ||
|
|
||
| Attested TLS comes in three different forms: |
There was a problem hiding this comment.
You could mention actual source here.
|
|
||
| - Generates ephemeral public and private keys for every connection. Thus, ensuring that the Agent is the only one who has access to the private key. | ||
| - Generates a fresh X.509 certificate based on the ephemeral public and private keys. | ||
| - Fetches the Evidence and embeds the public key and a cocos-cli-supplied nonce into the Evidence. The nonce is needed to ensure the Evidence's freshness. |
There was a problem hiding this comment.
You need to clarify the exact value of reportdata that you use here, with a pointer to the code for someone to audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a documentation update because it gives additional info on aTLS.
What does this do?
This PR gives additional details on
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified features?
Yes
Notes