Update RuboCop configuration, remove unused gem, and refactor some code#28
Merged
Merged
Conversation
tycooon
reviewed
Jul 9, 2026
tycooon
left a comment
Member
There was a problem hiding this comment.
Reviewed the refactor — mostly faithful, equivalent cleanups. The grep_v rewrites in check_spec_suffixes, the path.glob + relative_path_from switch (equivalent since path is Pathname.pwd), the raise/hash-shorthand tidy-ups, and dropping the unused ostruct gem (no OpenStruct usage anywhere) all look correct.
A few points, severity-ordered (details inline):
- P1
run_specs.rb—sort_by(&:size)drops the deterministic path tiebreaker; parallel nodes can silently skip or double-run specs. - P2
run_specs.rb—filter_map { e["id"] }silently drops examples thatfetchwould have caught. - P2
check_sidekiq_scheduler_config.rb—.to_set.to_ais a less-clear.uniq. - P2
lib/tasks/sequel_management.rake—filter_maponFile.basenamefilters nothing.
— Claude (AI code review, Opus)
yegorbelov
approved these changes
Jul 10, 2026
Contributor
Author
|
Hi @tycooon! I've addressed all the comments in commit abc1234. Thanks for the thorough review! Let me know if it looks ok now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tycooon! 👋
I noticed that ci_helper recently dropped support for old Rubies and now requires >= 3.2.0. I decided to do a quick pass over the commands to apply modern Ruby 3.2+ features (like removing require 'set' and using modern Hash syntax) to keep the codebase fresh and clean.