fix: add missing name field to 7 scaffolded skill templates

internal/agentkit/agentkit_test.go

@@ -1,6 +1,7 @@
 package agentkit
 
 import (
+	"io/fs"
 	"os"
 	"path/filepath"
 	"strings"
@@ -150,3 +151,65 @@ func TestScaffold_FileCount(t *testing.T) {
 		t.Errorf("agents = %d, want 3", agents)
 	}
 }
+
+func TestSkillTemplates_HaveNameField(t *testing.T) {
+	// Walk the embedded content filesystem and verify every SKILL.md
+	// has a "name: <directory-name>" field in its YAML frontmatter.
+	var checked int
+
+	err := fs.WalkDir(content, "content/skills", func(path string, d fs.DirEntry, err error) error {
+		if err != nil {
+			return err
+		}
+		if d.IsDir() || d.Name() != "SKILL.md" {
+			return nil
+		}
+
+		data, readErr := content.ReadFile(path)
+		if readErr != nil {
+			t.Errorf("read %s: %v", path, readErr)
+			return nil
+		}
+
+		text := string(data)
+
+		// Extract directory name (e.g., "always-on-guidance" from
+		// "content/skills/always-on-guidance/SKILL.md").
+		dir := filepath.Dir(path)
+		dirName := filepath.Base(dir)
+
+		// Verify frontmatter delimiters exist.
+		if !strings.HasPrefix(text, "---\n") {
+			t.Errorf("%s: missing opening frontmatter delimiter", path)
+			return nil
+		}
+		endIdx := strings.Index(text[4:], "\n---")
+		if endIdx < 0 {
+			t.Errorf("%s: missing closing frontmatter delimiter", path)
+			return nil
+		}
+		frontmatter := text[4 : 4+endIdx]
+
+		// Check for "name: <dirName>" line.
+		wantLine := "name: " + dirName
+		found := false
+		for _, line := range strings.Split(frontmatter, "\n") {
+			if strings.TrimSpace(line) == wantLine {
+				found = true
+				break
+			}
+		}
+		if !found {
+			t.Errorf("%s: frontmatter missing %q", path, wantLine)
+		}
+
+		checked++
+		return nil
+	})
+	if err != nil {
+		t.Fatalf("walk embedded skills: %v", err)
+	}
+	if checked != 7 {
+		t.Errorf("checked %d skill templates, want 7", checked)
+	}
+}

internal/agentkit/content/skills/always-on-guidance/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: always-on-guidance
 description: Global coding rules and tool usage discipline
 tags: [always-on, coding, quality]
 ---

internal/agentkit/content/skills/forge-coordination/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: forge-coordination
 description: Multi-agent coordination patterns for forge sessions
 tags: [forge, coordination, multi-agent]
 ---

internal/agentkit/content/skills/forge-global/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: forge-global
 description: Cross-project forge coordination patterns
 tags: [forge, global, coordination]
 ---

internal/agentkit/content/skills/learning-systems/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: learning-systems
 description: How the forge learns from outcomes
 tags: [learning, forge, insights]
 ---

internal/agentkit/content/skills/replicator-cli/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: replicator-cli
 description: Replicator CLI quick reference
 tags: [cli, reference, replicator]
 ---

internal/agentkit/content/skills/system-design/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: system-design
 description: System design principles for clean architecture
 tags: [design, architecture, principles]
 ---

internal/agentkit/content/skills/testing-patterns/SKILL.md

@@ -1,4 +1,5 @@
 ---
+name: testing-patterns
 description: Go testing patterns for the replicator project
 tags: [testing, go, patterns]
 ---