-
Notifications
You must be signed in to change notification settings - Fork 21
Default pdf templates #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@pozylon what do you think? and importable google wallet pass All imprts are with optional dependencies |
ea3fb7b to
ac07016
Compare
pozylon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments, there is various topics that needs a bit polishing. After that's done we need to check again how we can make the createPDFTicketRenderer actually useful to create customized tickets.
459d3fb to
860030e
Compare
pozylon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comes together nicely, now we need a factory patter for the pdf ticket renderer so someone can easily set logo, image, colors and such stuff to actually generate tickets that resemble a custom brand.
packages/ticketing/src/pdf-tickets/defaultTicketReceiptRenderer.ts
Outdated
Show resolved
Hide resolved
42b25ec to
820fd08
Compare
|
I haven't tested the apple wallet pass, please do on your end if you can |
288bab5 to
517fda9
Compare
|
It's hard to test this functionality as the ticketing example does currently not use the new functions, i'd expect something like this in the ticketing example: renderOrderPDF should be typed to something like this: Goal is to give users of the ticketing module a sane default to at least generate usable tickets. If the document generated is unusable it doesn't make sense to give helpers. It should actually print general tickets like in the theater or gastro projects but with a much more generalized design. User can do:
|
pozylon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment, although the way you structured it comes together well, the actual "value" for the developer is not leveraged
3cfe981 to
edf309b
Compare
15788ec to
db21131
Compare
|
@Mikearaya i have rebased this branch on master and did some code cleanups and added default initialization logic to the ticketing example with claude so make sure to hard reset before continuing your work. When done, we should be able to cleanup the Theater im Hof Repository substantially leveraging the factory functions to implement the simple ticket case. Please make sure the tests pass in the ticketing example and use that to test ticketing stuff. Somehow we need to be able to easily test the processes there so it should seed a product that is a ticket and do some checkout and everything. |
979ebb1 to
d291269
Compare
|
Added few more tests and fixed existing ones |
No description provided.