fix: Initialize default logger in AsyncPlaywrightCrawlerStrategy (#1704) #1718
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Fixes #1704
Details
When users directly instantiate
AsyncPlaywrightCrawlerStrategywithout passing a logger,self.loggerremainsNone. This causes crashes when the strategy attempts to log events, particularly during:The fix initializes a default
AsyncLogger(verbose=False)when no logger is provided, ensuring all logger calls succeed.Root Cause
From the issue analysis:
AsyncWebCrawlerdon't always provide loggersTest plan
🤖 Generated with Claude Code