fix: Update JavaScript functions

[sergioceron]

Automated fix by CoderOps.

Swarm: swarm50
Task: Update JavaScript functions

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

document.onclick assumes #servicelist always exists; on pages where the menu isn’t rendered (e.g., logged-out views), getElementById('servicelist') is null and .style will throw, breaking all click handling. Add a null-check (or early return) before reading .style.display (and ideally only register the handler when the element exists).

Suggested change

	document.onclick=function(event){
	if(document.getElementById('servicelist').style.display=="block"){
	hideItem('servicelist');
	}
	};
	var servicelist = document.getElementById('servicelist');
	if (servicelist) {
	document.onclick=function(event){
	if(servicelist.style.display=="block"){
	hideItem('servicelist');
	}
	};
	}

[Copilot]

window.onbeforeunload handler sets oEvent.returnValue but never returns the message. Some browsers only show the confirmation prompt when the handler returns a non-empty string; return msg when test_values_set() is true.

Suggested change

	oEvent.returnValue = msg;
	oEvent.returnValue = msg;
	return msg;

[Copilot]

This loop assigns to i, n, name, id, and ids without declarations, creating/overwriting globals (e.g., window.name) and risking cross-function interference. Declare these variables locally (e.g., var/let) inside deleteArticle.

Suggested change

	for (i=0,n=theForm.elements.length;i<n;i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	name = theForm.elements[i].name;
	id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	ids = name.substring( name.lastIndexOf( "." )+1 );
	for (var i=0, n=theForm.elements.length; i<n; i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	var name = theForm.elements[i].name;
	var id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	var ids = name.substring( name.lastIndexOf( "." )+1 );

[Copilot]

This loop assigns to i, n, name, id, and ids without declarations, creating/overwriting globals and risking cross-function interference. Declare these variables locally inside deleteArticleAdmin.

[Copilot]

This loop assigns to i, n, name, id, and ids without declarations, creating/overwriting globals and risking cross-function interference. Declare these variables locally inside deleteCategory.

Suggested change

	for (i=0,n=theForm.elements.length;i<n;i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	name = theForm.elements[i].name;
	id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	ids = name.substring( name.lastIndexOf( "." )+1 );
	for (var i=0, n=theForm.elements.length; i<n; i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	var name = theForm.elements[i].name;
	var id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	var ids = name.substring( name.lastIndexOf( "." )+1 );

[Copilot]

This loop assigns to i, n, name, id, and ids without declarations, creating/overwriting globals and risking cross-function interference. Declare these variables locally inside deleteSale.

Suggested change

	for (i=0,n=theForm.elements.length;i<n;i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	name = theForm.elements[i].name;
	id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	ids = name.substring( name.lastIndexOf( "." )+1 );
	for (var i=0, n=theForm.elements.length; i<n; i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	var name = theForm.elements[i].name;
	var id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	var ids = name.substring( name.lastIndexOf( "." )+1 );

[Copilot]

This loop assigns to i, n, name, id, and ids without declarations, creating/overwriting globals and risking cross-function interference. Declare these variables locally inside deleteUser.

Suggested change

	for (i=0,n=theForm.elements.length;i<n;i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	name = theForm.elements[i].name;
	id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	ids = name.substring( name.lastIndexOf( "." )+1 );
	for (var i=0, n=theForm.elements.length; i<n; i++)
	if (theForm.elements[i].name.indexOf('COLLECTION_SELECTION_') !=-1 && theForm.elements[i].checked == true){
	var name = theForm.elements[i].name;
	var id = name.substring( name.lastIndexOf( "_" )+1, name.lastIndexOf( "." ) );
	var ids = name.substring( name.lastIndexOf( "." )+1 );