Skip to content

fix: Remove existing user list code #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergioceron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Remove existing user list code #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
248 changes: 95 additions & 153 deletions adminpanel_users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,153 +1,95 @@
<?php
/**********************************************************************
* Author : Sergio Ceron Figueroa (sxceron@laciudadx.com)
* Alias : sxceron
* Web : http://www.dotrow.info
* Name : jShop v1.0
* Desc : Lista de usuarios clientes
*
***********************************************************************/
// Include file headers
include_once "./includes/utils.php";
include_once "./includes/validator.php";
include_once "./includes/settings.php";
include_once "./includes/db.php";
include_once "./includes/security.php";
if( $isadmin != 1 ) header( "Location: ./login.php" );

$sselected = 3; $subtitle = $_i18n[ "admin.users" ];$selected = 4;
$items = array( $_i18n["menu1"], $_i18n["admin.onhold"], $_i18n["admin.forsale"], $_i18n["categories.submenu"], $_i18n[ "admin.users" ], $_i18n[ "newproduct" ], $_i18n[ "newcategory" ] );
$links = array( "./adminpanel.php", "./adminpanel_sales.php", "./adminpanel_products.php","./adminpanel_categories.php", "./adminpanel_users.php", "./adminpanel_newproduct.php", "./adminpanel_newcategory.php" );
include("includes/header.php");$_validator = new Validator();
$fields = " ".base64_decode( $_GET[ "tk" ] );
?>

<div id="content"><?php if( isset( $_GET[ "id" ] ) ){ ?>
<div align="center" class="msg">
<div class="bl3">
<div class="br">
<div class="tl">
<div class="tr2"><?=$_i18n[ "userse".base64_decode( $_GET[ "id" ] ) ]?>
</div>
</div>
</div>
</div>
</div>
<?php } ?>
<ul class="inlinelist">
<li class="main1"><b><?=$_i18n["admin.createuser"]?></b></li>
</li>
</ul>
<p><?=$_i18n["users.info"]?></p>
<form action="adminpanel_register.php" method="post" id="settings"><input
type="hidden" name="at" value="7cf0ac816f615996-1128ad98933">
<table>
<tr>
<th style="text-align: left"><?=$_i18n["name"]?>: <font color="red">*</font></th>
<td><span class="errorbox-good"> <input type="text" name="name"
value="" id="fn" size="30"> </span> <?php if( strpos( $fields, 'name' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr>
<th><?=$_i18n["password"]?>: <font color="red">*</font></th>
<td><span class="errorbox-good"> <input type="password"
name="password" value="" id="" size="30"> </span> <?php if( strpos( $fields, 'password' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr>
<th>Tipo: <font color="red">*</font></th>
<td><span class="errorbox-good">
<select name="type">
<option value="0">Ponente/Conferencista</option>
<option value="1">Coautor</option>
<option value="2">Asistente</option>
<option value="3">Evaluador</option>
</select>
</span> <?php if( strpos( $fields, 'type' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr class="finalrow">
<th></th>
<td><input value="Agregar usuario" class="mainbutton"
onclick="clear_isset_monitoring();" type="submit"></td>
</tr>
</table>
</form>

<p>
<hr>
</p>

<?php
$usuarios = $db->get_results("select * from usuarios where usuario_tipo <> 1" );
?>
<form id="list" name="deleteItems"
action="adminpanel_process.php?sale=<?=base64_decode($values["cid"])?>"
method="post">
<table>
<tr>
<th colspan="3" class="tablebar"><input disabled="disabled"
value="<?=$_i18n["admin.deleteuser"]?>" id="deleteB"
onclick="return deleteUser(deleteItems, './adminpanel_deleteuser.php');"
type="button"></th>
<th colspan="4" class="tablebar">
<ul class="inlinelist">
<li id="count2"><b>1 - <?=count( $usuarios )?> de <?=count( $usuarios )?></b>
</li>
</ul>
</th>
</tr>
<tr>
<th id="header"></th>
<th id="header" style="width: 3%"><input value="" name="select_all"
onclick="cbTbl.selectAll(this); updateDeleteButtons(this);"
type="checkbox"></th>
<th id="header" style="width: 30%"><?=$_i18n["name"]?></th>
<th id="header">Tipo</th>
<th id="header">Ponencias</th>
<th id="header"><?=$_i18n["lastaccess"]?></th>
</tr>
<?php for( $i = 0;$i < count($usuarios); $i++){
$userPonencias = $db->get_results("select * from ponencias where usuario_id=".$usuarios[$i]->usuario_id);
?>
<tr class="" id="ARTICLE_COLLECTION_SELECTION_<?=$i?>">
<td></td>
<td><input value="true"
name="COLLECTION_SELECTION_<?=$i?>.<?=base64_encode($usuarios[$i]->usuario_id)?>"
onclick="cbTbl.selectOne(this); updateDeleteButtons(this);"
type="checkbox"></td>
<td><a href="javascript:void(0)"
onclick="go( 'adminpanel_edituser.php?user=<?=base64_encode($usuarios[$i]->usuario_id)?>' );return false"><?=$usuarios[$i]->usuario_alias?></a></td>
<td><?=getTipoUsuario($usuarios[$i]->usuario_tipo)?></td>
<td><?=count($userPonencias)?></td>
<td><?=(trim($usuarios[$i]->usuario_ultimoacceso) != "" ? $usuarios[$i]->usuario_ultimoacceso : $_i18n["notavailable"])?></td>
</tr>
<?php
}
if( $i == 0 ){
?>
<tr class="" id="ARTICLE_COLLECTION_SELECTION_0">
<td colspan="7" align="center"><em>No existe ningun usuario</em></td>
</tr>
<?php } ?>

<tr>
<th colspan="3" class="tablebar"><input disabled="disabled"
value="<?=$_i18n["admin.deleteuser"]?>" id="deleteT"
onclick="return deleteUser(deleteItems, './adminpanel_deleteuser.php');"
type="button"></th>
<th colspan="4" class="tablebar">
<ul class="inlinelist">
<li id="count"><b>1 - <?=count( $usuarios )?> de <?=count( $usuarios )?></b>
</li>
</ul>

</th>
</tr>
</table>
</form>
</div>
</div>
<?php include("./includes/foot.php");?>
</body>
</html>
<?php
/**********************************************************************
* Author : Sergio Ceron Figueroa (sxceron@laciudadx.com)
* Alias : sxceron
* Web : http://www.dotrow.info
* Name : jShop v1.0
* Desc : Lista de usuarios clientes
*
***********************************************************************/
// Include file headers
include_once "./includes/utils.php";
include_once "./includes/validator.php";
include_once "./includes/settings.php";
include_once "./includes/db.php";
include_once "./includes/security.php";
if( $isadmin != 1 ) header( "Location: ./login.php" );
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect for non-admin users sends a Location header but does not stop execution. The rest of the page can still render/execute server-side after the redirect is issued. Add an immediate exit/die after the header (or use a shared guard that terminates) to prevent unauthorized output and side effects.

Suggested change
if( $isadmin != 1 ) header( "Location: ./login.php" );
if( $isadmin != 1 ) {
header( "Location: ./login.php" );
exit;
}

Copilot uses AI. Check for mistakes.

$sselected = 3; $subtitle = $_i18n[ "admin.users" ];$selected = 4;
$items = array( $_i18n["menu1"], $_i18n["admin.onhold"], $_i18n["admin.forsale"], $_i18n["categories.submenu"], $_i18n[ "admin.users" ], $_i18n[ "newproduct" ], $_i18n[ "newcategory" ] );
$links = array( "./adminpanel.php", "./adminpanel_sales.php", "./adminpanel_products.php","./adminpanel_categories.php", "./adminpanel_users.php", "./adminpanel_newproduct.php", "./adminpanel_newcategory.php" );
include("includes/header.php");$_validator = new Validator();
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$_validator is instantiated but never used in this file. This is dead code and can mislead future changes (and may have side effects if Validator does setup work). Remove the unused instantiation or use it for actual validation.

Copilot uses AI. Check for mistakes.
$fields = " ".base64_decode( $_GET[ "tk" ] );
Comment on lines +21 to +22
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$_GET["tk"] is read unconditionally; when the parameter is absent this will raise a notice and base64_decode() will receive null. Use a default (e.g., $_GET['tk'] ?? '') and consider strict base64 decoding/validation before using it in strpos() checks.

Copilot uses AI. Check for mistakes.
?>

<div id="content"><?php if( isset( $_GET[ "id" ] ) ){ ?>
<div align="center" class="msg">
<div class="bl3">
<div class="br">
<div class="tl">
<div class="tr2"><?=$_i18n[ "userse".base64_decode( $_GET[ "id" ] ) ]?>
</div>
</div>
</div>
</div>
</div>
<?php } ?>
<ul class="inlinelist">
<li class="main1"><b><?=$_i18n["admin.createuser"]?></b></li>
</li>
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra closing </li> which results in invalid HTML structure for the inline list. Remove the stray closing tag so the <ul> contains only properly paired <li> elements.

Suggested change
</li>

Copilot uses AI. Check for mistakes.
</ul>
<p><?=$_i18n["users.info"]?></p>
<form action="adminpanel_register.php" method="post" id="settings"><input
type="hidden" name="at" value="7cf0ac816f615996-1128ad98933">
<table>
<tr>
<th style="text-align: left"><?=$_i18n["name"]?>: <font color="red">*</font></th>
<td><span class="errorbox-good"> <input type="text" name="name"
value="" id="fn" size="30"> </span> <?php if( strpos( $fields, 'name' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr>
<th><?=$_i18n["password"]?>: <font color="red">*</font></th>
<td><span class="errorbox-good"> <input type="password"
name="password" value="" id="" size="30"> </span> <?php if( strpos( $fields, 'password' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr>
<th>Tipo: <font color="red">*</font></th>
<td><span class="errorbox-good">
<select name="type">
<option value="0">Ponente/Conferencista</option>
<option value="1">Coautor</option>
<option value="2">Asistente</option>
<option value="3">Evaluador</option>
</select>
</span> <?php if( strpos( $fields, 'type' ) ){?><br>
<span class="errormsg" id="errormsg_0"> <?=$_i18n["emptyfield"]?> </span><?php } ?></td>
</tr>
<tr class="finalrow">
<th></th>
<td><input value="Agregar usuario" class="mainbutton"
onclick="clear_isset_monitoring();" type="submit"></td>
</tr>
</table>
</form>

<p>
<hr>
</p>

<?php

?>
Comment on lines +81 to +83
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty PHP block left in place; it no longer does anything and adds noise around the removed list section. Remove the empty <?php ... ?> section to keep the template clean.

Suggested change
<?php
?>

Copilot uses AI. Check for mistakes.
<form id="list" name="deleteItems"
action="adminpanel_process.php?sale=<?=base64_decode($values["cid"])?>"
method="post">



</form>
Comment on lines +81 to +90
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user list UI was removed, but an empty <form id="list" ...> remains and its action references $values["cid"], which is not defined anywhere in this file (and only used here). This will trigger notices and the form no longer serves a purpose—either remove the form entirely or define/populate the required values and include the fields the handler expects.

Suggested change
<?php
?>
<form id="list" name="deleteItems"
action="adminpanel_process.php?sale=<?=base64_decode($values["cid"])?>"
method="post">
</form>

Copilot uses AI. Check for mistakes.
</div>
</div>
<?php include("./includes/foot.php");?>
</body>
</html>