fix: Remove User List feature

[sergioceron]

Automated fix by CoderOps.

Swarm: swarm50
Task: Remove User List feature

[Copilot]

Pull request overview

Removes the “User List” section from the admin users page (adminpanel_users.php) as part of retiring the User List feature in the admin panel.

Changes:

• Deleted the DB query + table UI that listed users and allowed selection/deletion.
• Left the “create user” form as the primary content on the page.
• Simplified/trimmed parts of the surrounding page markup (but currently leaves broken remnants).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The admin redirect only calls header(); execution continues and can still render the page for non-admins. Wrap the redirect in a block and exit immediately after sending the Location header.

Suggested change

	if( $isadmin != 1 ) header( "Location: ./login.php" );
	if( $isadmin != 1 ) {
	header( "Location: ./login.php" );
	exit;
	}

[Copilot]

$_GET['tk'] is decoded unconditionally. If tk is missing (or not valid base64), this will raise notices and can make strpos() checks behave unexpectedly. Default to an empty string when the parameter is absent and only decode when present/valid.

Suggested change

	$fields = " ".base64_decode( $_GET[ "tk" ] );
	$fields = "";
	if( isset( $_GET[ "tk" ] ) ){
	$decodedFields = base64_decode( $_GET[ "tk" ], true );
	if( $decodedFields !== false ){
	$fields = " ".$decodedFields;
	}
	}

[Copilot]

The status/message banner now always renders and references $_GET['id'] without an isset() guard. This will trigger undefined index notices when id isn't provided, and may also produce an undefined $_i18n key. Restore the previous conditional rendering (or provide a safe default) before decoding/using id.

Suggested change

	<div align="center" class="msg">
	<div class="bl3">
	<div class="br">
	<div class="tl">
	<div class="tr2"><?=$_i18n[ "userse".base64_decode( $_GET[ "id" ] ) ]?>
	</div>
	</div>
	</div>
	</div>
	</div>
	<?php
	if( isset( $_GET[ "id" ] ) ){
	$_messageKey = "userse".base64_decode( $_GET[ "id" ] );
	if( isset( $_i18n[ $_messageKey ] ) ){
	?>
	<div align="center" class="msg">
	<div class="bl3">
	<div class="br">
	<div class="tl">
	<div class="tr2"><?=$_i18n[ $_messageKey ]?>
	</div>
	</div>
	</div>
	</div>
	</div>
	<?php
	}
	}
	?>

[Copilot]

This block still contains remnants of the removed user list: a <tr> outside of any <table>, references to $i, $usuarios, and $userPonencias that are never defined, and a stray } inside a PHP block. As written this will cause PHP parse/runtime errors and broken HTML. Either delete this entire list-row fragment (if the feature is being removed) or reintroduce the missing query/loop and surrounding table markup.

Suggested change

	<tr class="" id="ARTICLE_COLLECTION_SELECTION_<?=$i?>">
	<td></td>
	<td><input value="true"
	name="COLLECTION_SELECTION_<?=$i?>.<?=base64_encode($usuarios[$i]->usuario_id)?>"
	onclick="cbTbl.selectOne(this); updateDeleteButtons(this);"
	type="checkbox"></td>
	<td><a href="javascript:void(0)"
	onclick="go( 'adminpanel_edituser.php?user=<?=base64_encode($usuarios[$i]->usuario_id)?>' );return false"><?=$usuarios[$i]->usuario_alias?></a></td>
	<td><?=getTipoUsuario($usuarios[$i]->usuario_tipo)?></td>
	<td><?=count($userPonencias)?></td>
	<td><?=(trim($usuarios[$i]->usuario_ultimoacceso) != "" ? $usuarios[$i]->usuario_ultimoacceso : $_i18n["notavailable"])?></td>
	</tr>
	<?php
	}
	if( $i == 0 ){
	?>

[Copilot]

The file header comment still says "Lista de usuarios clientes", but the PR intent is to remove the user list and the list section has been deleted. Update the description to reflect the page’s remaining purpose (e.g., user creation/status messaging) to avoid misleading documentation.

Suggested change

	* Desc : Lista de usuarios clientes
	* Desc : Alta de usuarios y mensajes de estado

[Copilot]

The closing tags at the end of the file don’t match the elements opened above (there are two </div> closings but only one remaining open wrapper after the message banner). After removing the user list section, re-check and fix the HTML structure so all opened containers are closed exactly once.

Suggested change

</div>