fix: Update JavaScript functionalities#41
Open
sergioceron wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be an automated update to the shared admin/control-panel JavaScript (jscripts/cpanel.js), attempting to extend checkbox/table interactions with an optional userTableId parameter.
Changes:
- Added
userTableIdparameters toswitchItem(...)andupdateDeleteButtons(...). - Modified
cbTbl.selectOneto attempt table lookup viauserTableIdbefore falling back to DOM traversal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+316
to
+321
| cbTbl.selectOne = function(cb) { | ||
| cbTbl.highlight(cb); | ||
| // Update status of 'Select All' checkbox appropriately. | ||
| // The first ('Select All') cb should be selected IFF all the | ||
| // rest are checked, | ||
| var tbl = document.getElementById(userTableId) || cbTbl.findContainingTable(cb); |
Comment on lines
+169
to
+176
| function updateDeleteButtons(cb, userTableId) { | ||
| if (cbTbl.numberChecked(cb, userTableId) == 0) { | ||
| disAble('deleteT'); | ||
| disAble('deleteB'); | ||
| } else { | ||
| enAble('deleteT'); | ||
| enAble('deleteB'); | ||
| } |
Comment on lines
+60
to
+67
| function switchItem(which, userTableId) { | ||
| switchItem2(currentItem, which, userTableId); | ||
| currentItem=which; | ||
| }; | ||
|
|
||
| /* hide one item, show another */ | ||
| function switchItem2(toHide,toShow) { | ||
| hideItem(toHide); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by CoderOps.
Swarm: swarm50
Task: Update JavaScript functionalities