ci: harden nightly integration workflow — drop artifact upload#3
Open
ci: harden nightly integration workflow — drop artifact upload#3
Conversation
Steelman warning from post-merge review: the on-failure upload-artifact
step harvested /tmp/sphere-cli-it-*/ into 7-day GitHub Actions storage.
Those dirs hold secp256k1 testnet wallet material (mnemonic + private
key) that the integration helpers explicitly shred on exit for hygiene
reasons — uploading the same material as an artifact defeats that.
Even though the keys are throwaway and hold no funds, harvesting them
fails principle-of-least-privilege and could leak into CI logs, Slack
paste-backs, or tickets.
Also while here:
* permissions: contents: read — least-privilege default
* concurrency: group:integration-nightly — prevent cron+dispatch
double-hammering public testnet infra
* sphere-sdk SHA pin — aligned with ci.yml (was branch-pinned)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge steelman finding: nightly workflow's on-failure artifact upload harvests secp256k1 testnet wallet material into 7-day GitHub storage. The integration helpers already shred those dirs on exit for the same hygiene reason — uploading them defeats that.
Changes
Test plan