fix(host): pre-flight --timeout floor at MIN_TIMEOUT_MS=100#4
Merged
Conversation
Aligns with agentic-hosting's tenant-side dispatcher (command-registry.ts) which rejects timeout_ms < 100 with invalid_params. Without this CLI preflight, an operator sending --timeout 50 sees a confusing two-hop error path: CLI accepts → manager forwards → tenant rejects with invalid_params far from the source. Now the CLI fails immediately with a clear message: Invalid timeout: 50 (minimum 100ms — values below this are rejected by the tenant dispatcher) Tests: +2 (rejects below 100, accepts at/above 100). 26 total in host-commands.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns sphere-cli's `sphere host --timeout` floor with agentic-hosting's tenant dispatcher, which now rejects `timeout_ms < 100` with `invalid_params` (introduced in PR #17 of agentic-hosting).
Without this preflight, `--timeout 50` succeeds at CLI parse, succeeds at manager HMCP forward, then fails at the tenant with a confusing two-hop error. Now the CLI fails immediately at the source with a clear message.
Test plan
Cross-repo coordination
This is one of the round-2 steelman fixes; matching tenant-side fix is in agentic-hosting branch `fix/tenant-cmd-round2` (currently in flight).