Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions executors/dart/lib/datetime_format.dart
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ String testDateTimeFmt(String jsonEncoded) {
}
returnJson['actual_options'] = {
'locale': locale.toString(),
if (dateStyle != null) 'dateStyle': dateStyle,
if (timeStyle != null) 'timeStyle': timeStyle,
'dateStyle': ?dateStyle,
'timeStyle': ?timeStyle,
Comment on lines +140 to +141

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The syntax 'dateStyle': ?dateStyle is invalid in Dart and will cause a compilation error. Dart does not support the ? prefix operator for map values or entries. If you want to conditionally include these keys only when they are non-null (consistent with yearStyle and calendar below), you should use the if (variable != null) collection-if syntax. If you want to always include the keys (even with null values), simply use dateStyle and timeStyle without the ? prefix.

Suggested change
'dateStyle': ?dateStyle,
'timeStyle': ?timeStyle,
if (dateStyle != null) 'dateStyle': dateStyle,
if (timeStyle != null) 'timeStyle': timeStyle,

if (yearStyle != null) 'yearStyle': yearStyle.name,
if (calendar != null) 'calendar': calendar.jsName,
};
Expand Down
2 changes: 1 addition & 1 deletion executors/dart/lib/version.dart
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/// This file is autogenerated by bin/set_version.dart, do not modify manually.
const intl4xVersion = '0.17.0';
const intl4xVersion = '1.0.0-alpha.1';
2 changes: 1 addition & 1 deletion executors/dart/out/version.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
const dartVersion = "0.17.0";
const dartVersion = "1.0.0-alpha.1";
module.exports = { dartVersion };
94 changes: 47 additions & 47 deletions executors/dart/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@ packages:
dependency: transitive
description:
name: _fe_analyzer_shared
sha256: "5b7468c326d2f8a4f630056404ca0d291ade42918f4a3c6233618e724f39da8e"
sha256: f6526c100095fd63a916824e3da344bbbd50c25c8f56bcd52d13c59d35bbe422
url: "https://pub.dev"
source: hosted
version: "92.0.0"
version: "104.0.0"
analyzer:
dependency: transitive
description:
name: analyzer
sha256: "70e4b1ef8003c64793a9e268a551a82869a8a96f39deb73dea28084b0e8bf75e"
sha256: "6c6d751533496152e78f71c46ad001260c5e74e0f9ec1f1cbc165a0467c086d6"
url: "https://pub.dev"
source: hosted
version: "9.0.0"
version: "14.0.0"
args:
dependency: transitive
description:
Expand All @@ -29,10 +29,10 @@ packages:
dependency: transitive
description:
name: async
sha256: "758e6d74e971c3e5aceb4110bfd6698efc7f501675bcfe0c775459a8140750eb"
sha256: e2eb0491ba5ddb6177742d2da23904574082139b07c1e33b8503b9f46f3e1a37
url: "https://pub.dev"
source: hosted
version: "2.13.0"
version: "2.13.1"
boolean_selector:
dependency: transitive
description:
Expand Down Expand Up @@ -61,10 +61,10 @@ packages:
dependency: transitive
description:
name: code_assets
sha256: "83ccdaa064c980b5596c35dd64a8d3ecc68620174ab9b90b6343b753aa721687"
sha256: bf394f466ba9205f1812a0433b392d6af280f155f56651eda7c18cc32ed493b8
url: "https://pub.dev"
source: hosted
version: "1.0.0"
version: "1.2.1"
collection:
dependency: "direct main"
description:
Expand All @@ -85,10 +85,10 @@ packages:
dependency: transitive
description:
name: coverage
sha256: "5da775aa218eaf2151c721b16c01c7676fbfdd99cebba2bf64e8b807a28ff94d"
sha256: "956a3de0725ca232ad353565a8290d3357592bf4250f6f298a185e2d949c5d3d"
url: "https://pub.dev"
source: hosted
version: "1.15.0"
version: "1.15.1"
crypto:
dependency: transitive
description:
Expand All @@ -101,10 +101,10 @@ packages:
dependency: transitive
description:
name: ffi
sha256: "289279317b4b16eb2bb7e271abccd4bf84ec9bdcbe999e278a94b804f5630418"
sha256: "6d7fd89431262d8f3125e81b50d3847a091d846eafcd4fdb88dd06f36d705a45"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
version: "2.2.0"
file:
dependency: transitive
description:
Expand Down Expand Up @@ -133,10 +133,10 @@ packages:
dependency: transitive
description:
name: hooks
sha256: "5d309c86e7ce34cd8e37aa71cb30cb652d3829b900ab145e4d9da564b31d59f7"
sha256: "9a62a50b50b769a737bc0a8ff381f333529df3ab746b2f6b02e83760231455ba"
url: "https://pub.dev"
source: hosted
version: "1.0.0"
version: "2.0.2"
http:
dependency: transitive
description:
Expand Down Expand Up @@ -165,18 +165,18 @@ packages:
dependency: transitive
description:
name: icu4x
sha256: "8c2f3ed5f860c68be13076e43685f49330956a8a8c351c9af7920606be411368"
sha256: "5a1709cbca00ded6304082292995c503d33f20544867f7226f8ee646128c4494"
url: "https://pub.dev"
source: hosted
version: "2.1.0-dev.1"
version: "2.2.0-dev.2"
intl4x:
dependency: "direct main"
description:
name: intl4x
sha256: "30170321747219904977b4826dbd5156e34f407876f87695d8b8167da5955d20"
sha256: "9bde13391a36b16ad25ac0c8ac3f777c47d74216973f21b59c682b9222871cd6"
url: "https://pub.dev"
source: hosted
version: "0.17.0"
version: "1.0.0-alpha.1"
io:
dependency: transitive
description:
Expand All @@ -189,18 +189,18 @@ packages:
dependency: transitive
description:
name: json_annotation
sha256: "1ce844379ca14835a50d2f019a3099f419082cfdd231cd86a142af94dd5c6bb1"
sha256: "2a743920d81b7910627f68ee2c9ac1fc0bfee32b9fc3403587d7c6791ca12f80"
url: "https://pub.dev"
source: hosted
version: "4.9.0"
version: "4.12.0"
lints:
dependency: "direct dev"
description:
name: lints
sha256: a5e2b223cb7c9c8efdc663ef484fdd95bb243bff242ef5b13e26883547fce9a0
sha256: "12f842a479589fea194fe5c5a3095abc7be0c1f2ddfa9a0e76aed1dbd26a87df"
url: "https://pub.dev"
source: hosted
version: "6.0.0"
version: "6.1.0"
logging:
dependency: transitive
description:
Expand All @@ -213,18 +213,18 @@ packages:
dependency: transitive
description:
name: matcher
sha256: "12956d0ad8390bbcc63ca2e1469c0619946ccb52809807067a7020d57e647aa6"
sha256: "31bd099b47c10cd1aeb55146a2d46ce0277630ecef3f7dae54ad7873f36696cd"
url: "https://pub.dev"
source: hosted
version: "0.12.18"
version: "0.12.20"
meta:
dependency: "direct dev"
description:
name: meta
sha256: "23f08335362185a5ea2ad3a4e597f1375e78bce8a040df5c600c8d3552ef2394"
sha256: c82594181e3312f3d0695fc95aaaf7758d75b8d4ae2bbecf223b9fd5109a059d
url: "https://pub.dev"
source: hosted
version: "1.17.0"
version: "1.18.3"
mime:
dependency: transitive
description:
Expand All @@ -237,10 +237,10 @@ packages:
dependency: transitive
description:
name: native_toolchain_c
sha256: "89e83885ba09da5fdf2cdacc8002a712ca238c28b7f717910b34bcd27b0d03ac"
sha256: f9c168717100ae6d9fee9ffb0be379bf1f8b26b0f6bcbd4fdddcd931993a6a72
url: "https://pub.dev"
source: hosted
version: "0.17.4"
version: "0.19.2"
node_preamble:
dependency: "direct main"
description:
Expand All @@ -253,10 +253,10 @@ packages:
dependency: transitive
description:
name: package_config
sha256: f096c55ebb7deb7e384101542bfba8c52696c1b56fca2eb62827989ef2353bbc
sha256: ffcf4cf3d6c0b74ac43708d9f56625506e8a68aa935abe9d267a7330f320eb5d
url: "https://pub.dev"
source: hosted
version: "2.2.0"
version: "3.0.0"
path:
dependency: transitive
description:
Expand Down Expand Up @@ -293,10 +293,10 @@ packages:
dependency: transitive
description:
name: record_use
sha256: d3d59b18ca7aa1ce689bb3b3fd982bbebdfcd9e89f977576486a55e3b0f19a27
sha256: "2551bd8eecfe95d14ae75f6021ad0248be5c27f138c2ec12fcb52b500b3ba1ed"
url: "https://pub.dev"
source: hosted
version: "0.4.2"
version: "0.6.0"
shelf:
dependency: transitive
description:
Expand Down Expand Up @@ -349,10 +349,10 @@ packages:
dependency: transitive
description:
name: source_span
sha256: "254ee5351d6cb365c859e20ee823c3bb479bf4a293c22d17a9f1bf144ce86f7c"
sha256: "56a02f1f4cd1a2d96303c0144c93bd6d909eea6bee6bf5a0e0b685edbd4c47ab"
url: "https://pub.dev"
source: hosted
version: "1.10.1"
version: "1.10.2"
stack_trace:
dependency: transitive
description:
Expand Down Expand Up @@ -389,34 +389,34 @@ packages:
dependency: "direct dev"
description:
name: test
sha256: "77cc98ea27006c84e71a7356cf3daf9ddbde2d91d84f77dbfe64cf0e4d9611ae"
sha256: "0d5ba5602ec3baa28c8ce365e1efc5575969c765f45c554a3e167dc7945b9c30"
url: "https://pub.dev"
source: hosted
version: "1.28.0"
version: "1.31.2"
test_api:
dependency: transitive
description:
name: test_api
sha256: "19a78f63e83d3a61f00826d09bc2f60e191bf3504183c001262be6ac75589fb8"
sha256: "475610b2aa23c19687cce2961e44b0cc57cafe220f67c2b80201231b2a07fbe7"
url: "https://pub.dev"
source: hosted
version: "0.7.8"
version: "0.7.13"
test_core:
dependency: transitive
description:
name: test_core
sha256: f1072617a6657e5fc09662e721307f7fb009b4ed89b19f47175d11d5254a62d4
sha256: a39c204a4fc7a7ccb04a2b985e359fda3cc37e45e0b8ac61c3fb1a05aa832132
url: "https://pub.dev"
source: hosted
version: "0.6.14"
version: "0.6.19"
timezone:
dependency: transitive
description:
name: timezone
sha256: dd14a3b83cfd7cb19e7888f1cbc20f258b8d71b54c06f79ac585f14093a287d1
sha256: "981d1020d6ef8fe1e7b3de5054e5b25579ae7c403d7734adc508ffc47668e9cb"
url: "https://pub.dev"
source: hosted
version: "0.10.1"
version: "0.11.1"
typed_data:
dependency: transitive
description:
Expand All @@ -429,18 +429,18 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: "45caa6c5917fa127b5dbcfbd1fa60b14e583afdc08bfc96dda38886ca252eb60"
sha256: "0016aef94fc66495ac78af5859181e3f3bf2026bd8eecc72b9565601e19ab360"
url: "https://pub.dev"
source: hosted
version: "15.0.2"
version: "15.2.0"
watcher:
dependency: transitive
description:
name: watcher
sha256: f52385d4f73589977c80797e60fe51014f7f2b957b5e9a62c3f6ada439889249
sha256: "1398c9f081a753f9226febe8900fce8f7d0a67163334e1c94a2438339d79d635"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
version: "1.2.1"
web:
dependency: transitive
description:
Expand Down Expand Up @@ -482,4 +482,4 @@ packages:
source: hosted
version: "3.1.3"
sdks:
dart: ">=3.10.0 <4.0.0"
dart: ">=3.12.0 <4.0.0"
10 changes: 5 additions & 5 deletions executors/dart/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ name: dart_executor
publish_to: none

environment:
sdk: ^3.10.0
sdk: ^3.12.0

dependencies:
collection: ^1.19.1
intl4x: 0.17.0
intl4x: 1.0.0-alpha.1
node_preamble: ^2.0.2
pubspec_lock_parse: ^2.2.0

dev_dependencies:
lints: ^6.0.0
meta: ^1.17.0
test: ^1.28.0
lints: ^6.1.0
meta: ^1.18.3
test: ^1.31.2


hook:
Expand Down
Loading