Skip to content

Update github-to-astro script#71

Open
Manishearth wants to merge 1 commit intounicode-org:mainfrom
Manishearth:script-up
Open

Update github-to-astro script#71
Manishearth wants to merge 1 commit intounicode-org:mainfrom
Manishearth:script-up

Conversation

@Manishearth
Copy link
Copy Markdown
Member

  • Sets astroVersion by default (the end result of it having it be mentioned in the help text is that it just gets copied by people anyway.
  • Uses path.resolve() so that absolute paths work for icu4xDir

@Manishearth
Copy link
Copy Markdown
Member Author

r? @echeran

Should we update astroVersion to 6.0? Instead of having it be a default should we try and detect the latest version and help the user with that?

Copy link
Copy Markdown
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we can replace it with 6.0

@robertbastian
Copy link
Copy Markdown
Member

Our package-lock.json has 5.14.7...

@Manishearth
Copy link
Copy Markdown
Member Author

I don't quite understand the implications of selecting a version here and what needs to be done to update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants