Merged
Conversation
markusicu
requested review from
echeran,
eggrobin,
josh-hadley,
jowilco,
macchiati and
nedley
josh-hadley
previously approved these changes
Apr 24, 2026
markusicu
force-pushed
the
remove-UVERSION
branch
from
901ba11 to
d66ad52
Compare
Member
Author
|
@josh-hadley thanks for the quick approval! However, spotless was unhappy, so I pushed a small fix. PTAL |
nedley
approved these changes
Apr 24, 2026
eggrobin
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the only class that looks at the UVERSION environment variable -- GenerateUnihanCollators -- to just use Settings.latestVersion, and then remove UVERSION from build scripts and instructions.
Fixes #376