Draft
Conversation
markusicu
requested review from
echeran,
eggrobin,
josh-hadley,
jowilco,
macchiati and
nedley
mihnita
reviewed
Apr 24, 2026
mihnita
approved these changes
Apr 24, 2026
Member
Author
|
Taking this down to draft while begging Mihai to help fix the Java version conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My machine updated to Java 25, and spotless throws exceptions.
I updated spotless to the same version that ICU is using for the last couple of months, and the underlying google-java-format to its latest version.
Then I ran spotless, and it changed a few files. Mostly (maybe only), comments before a switch-case are indented only as much as the
case CONSTANT, not as much as the preceding case body code.@mihnita FYI