Open
Conversation
Manishearth
requested changes
Feb 29, 2024
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Couple issues:
- I'm not sure I want to maintain or review this.
- There are a lot of unrelated changes to the rest of the code. I'm not sure if I'm going to actually review this, but I don't plan to until the PR is performing a single task.
Merged
Jules-Bertholet
force-pushed
the
ks_x_1026-1
branch
7 times, most recently
from
aa64aa5 to
6b86cc2
Compare
Jules-Bertholet
force-pushed
the
ks_x_1026-1
branch
from
6b86cc2 to
efd900b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the alternate normalizations defined by Korean Standard KS X 1026-1 (Korean, English) behind a new
ks_x_1026-1feature flag.