Fixes for debug formatting#22
Merged
Manishearth merged 1 commit intounicode-rs:masterfrom Aug 14, 2025
Merged
Conversation
Contributor
dcsommer
commented
Aug 14, 2025
dcsommer
commented
- Debug now prints full values for the internal representation, which is more helpful when combined with a hex or binary debug printing mode.
- Display now properly renders all the scripts with " + " separators.
dcsommer
force-pushed
the
debug-printing
branch
from
fe18fa6 to
78bae46
Compare
Member
|
I'm opposed to retargeting the Debug impl. Most of the time someone using this crate cares will need one so they can slap derive(Debug) on a struct containing it, and as such clients of this crate should never have to care about the internal implementation. A debug impl that exposes the internal bitfields is primarily useful for people working on this crate itself, which is not a great tradeoff: if I'm working on this crete I can always temporarily tweak its Debug impl if I need. |
`Debug` and `Display` now properly print all the scripts with " + " seperators.
dcsommer
force-pushed
the
debug-printing
branch
from
78bae46 to
d4936cb
Compare
Contributor
Author
|
Fair enough. Limited the PR to bug fix for |
Manishearth
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.