feat(examples): Add Tyk example using base image#131
Open
razvand wants to merge 1 commit into
Open
Conversation
Introduce a Tyk example to be deployed on Unikraft Cloud using the `base` (or `base-compat` image) Add: * `Kraftfile`: build / run rules * `Dockerfile`: build the Tyk application filesystem * `rootfs/etc/tyk.conf`: a simple Tyk configuration file * `README.md`: document how to use * `.dockerignore` / `.gitignore`: ignore generated files Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
craciunoiuc
reviewed
Dec 5, 2024
| spec: v0.6 | ||
|
|
||
| runtime: base:latest | ||
| #runtime: base-compat:latest |
Contributor
There was a problem hiding this comment.
is this left in intentionally?
craciunoiuc
reviewed
Dec 5, 2024
| build: . | ||
| ports: | ||
| - 443:8080 | ||
| #mem_reservation: 512M |
craciunoiuc
reviewed
Dec 5, 2024
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
looks good, left 2 comments
Contributor
Author
|
@craciunoiuc , in case you want to use the |
Contributor
|
Leave them like that and add a mention that they are related in the Readme, so people know they need to uncomment both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a Tyk example to be deployed on Unikraft Cloud using the
base(orbase-compatimage)Add:
Kraftfile: build / run rulesDockerfile: build the Tyk application filesystemrootfs/etc/tyk.conf: a simple Tyk configuration fileREADME.md: document how to use.dockerignore/.gitignore: ignore generated files