fix(workflows): add example with latest version of Nginx#219
Conversation
Signed-off-by: Assia AIT LAMALEM <assia.aitlamalem@gmail.com>
67e9c8d to
5cea276
Compare
razvand
left a comment
There was a problem hiding this comment.
Why are updates to the index.html and app-nginx?
For the actual workflow files, copy and adapt from existing workflow files, no need to start from scratch.
| @@ -1,6 +1,6 @@ | |||
| spec: v0.6 | |||
|
|
|||
| runtime: base-compat:latest | |||
| runtime: index.unikraft.io/official/nginx:latest | |||
There was a problem hiding this comment.
Hi @razvand,
Thanks for the review and the feedback! I understand the confusion regarding the extra changes. My goal was to update the example to ensure it uses the most robust and maintainable approach for the latest Nginx version.
…fy example scope as requested.
… file changes as requested.
razvand
left a comment
There was a problem hiding this comment.
You have an nginx-1.25/app-nginx` symbolic link or something weird. Remove it.
Use only two commit messages: one for moving the current nginx/ directory to nginx-1.25/ and another for adding the current nginx-1.27/ directory.
The .github/workflow/ directory is in the root directory of the repository, not a subdirectory of an example.
Write good commit messages. See the commit history, and use similar messages. Sign-off your commits.
|
Pls update the version of the existing nginx example instead |
This PR adds GitHub Actions workflows for building and testing the latest Nginx example:
The workflows build the Nginx example using KraftKit and verify it with a curl request to localhost:8080.