Skip to content

fix(workflows): add example with latest version of Nginx#219

Open
assiaait wants to merge 5 commits into
unikraft-cloud:mainfrom
assiaait:add-nginx-latest
Open

fix(workflows): add example with latest version of Nginx#219
assiaait wants to merge 5 commits into
unikraft-cloud:mainfrom
assiaait:add-nginx-latest

Conversation

@assiaait

@assiaait assiaait commented Dec 6, 2025

Copy link
Copy Markdown

This PR adds GitHub Actions workflows for building and testing the latest Nginx example:

  • .github/workflows/example-nginx-stable.yaml
  • .github/workflows/example-nginx-staging.yaml

The workflows build the Nginx example using KraftKit and verify it with a curl request to localhost:8080.

@assiaait

assiaait commented Dec 6, 2025

Copy link
Copy Markdown
Author

Hi @razvand,

This is a draft PR for adding Nginx example workflows.

Please review and give feedback.

Direct commit link: 67e9c8d
Full PR link: #219

Signed-off-by: Assia AIT LAMALEM <assia.aitlamalem@gmail.com>
@razvand razvand self-requested a review December 11, 2025 22:44

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are updates to the index.html and app-nginx?

For the actual workflow files, copy and adapt from existing workflow files, no need to start from scratch.

Comment thread nginx-1.25/Kraftfile
@@ -1,6 +1,6 @@
spec: v0.6

runtime: base-compat:latest
runtime: index.unikraft.io/official/nginx:latest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the runtime?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @razvand,

Thanks for the review and the feedback! I understand the confusion regarding the extra changes. My goal was to update the example to ensure it uses the most robust and maintainable approach for the latest Nginx version.

@razvand razvand self-assigned this Dec 11, 2025
@razvand razvand added the enhancement New feature or request label Dec 11, 2025

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an nginx-1.25/app-nginx` symbolic link or something weird. Remove it.

Use only two commit messages: one for moving the current nginx/ directory to nginx-1.25/ and another for adding the current nginx-1.27/ directory.

The .github/workflow/ directory is in the root directory of the repository, not a subdirectory of an example.

Write good commit messages. See the commit history, and use similar messages. Sign-off your commits.

nurof3n pushed a commit that referenced this pull request Mar 24, 2026
Update Cargo.lock to fix:
- Alert #219: bytes <1.11.1 (medium severity)
- Alert #223: time <0.3.47 (medium severity)

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
dragosgheorghioiu pushed a commit that referenced this pull request Apr 7, 2026
Update Cargo.lock to fix:
- Alert #219: bytes <1.11.1 (medium severity)
- Alert #223: time <0.3.47 (medium severity)

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
dragosgheorghioiu pushed a commit that referenced this pull request Apr 7, 2026
Update Cargo.lock to fix:
- Alert #219: bytes <1.11.1 (medium severity)
- Alert #223: time <0.3.47 (medium severity)

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
dragosgheorghioiu pushed a commit that referenced this pull request Apr 7, 2026
Update Cargo.lock to fix:
- Alert #219: bytes <1.11.1 (medium severity)
- Alert #223: time <0.3.47 (medium severity)

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
@nurof3n

nurof3n commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Pls update the version of the existing nginx example instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants