chore: Format examples for guides#256
Merged
Merged
Conversation
Signed-off-by: Alex-Andrei Cioc <andrei.cioc@unikraft.io>
nurof3n
force-pushed
the
nurof3n/chore/format-guides
branch
from
5a47399 to
860c235
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nurof3n
force-pushed
the
nurof3n/chore/format-guides
branch
4 times, most recently
from
588bd27 to
3a4e31a
Compare
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
|
|
||
| ```ansi | ||
| NAME FQDN STATE STATUS IMAGE MEMORY VCPUS ARGS BOOT TIME | ||
| grafana-sikrv icy-sea-i6m5fwyk.fra.unikraft.app running 11 minutes ago grafana@sha256:484d6f98c... 2048 MiB 1 /usr/share/grafana/bin/grafana server... 502651us |
Contributor
There was a problem hiding this comment.
why is time in us it should be in ms?
Contributor
Author
There was a problem hiding this comment.
inconsistency from whoever wrote this. we should do a separate PR to rewrite the "deployed successfully" output block and list for each example
craciunoiuc
reviewed
Apr 1, 2026
craciunoiuc
reviewed
Apr 1, 2026
Signed-off-by: Alex-Andrei Cioc <andrei.cioc@unikraft.io>
nurof3n
force-pushed
the
nurof3n/chore/format-guides
branch
from
3a4e31a to
9c33034
Compare
dragosgheorghioiu
approved these changes
Apr 1, 2026
dragosgheorghioiu
left a comment
dragosgheorghioiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Dragos Gheorghioiu dragosg@unikraft.com
Approved-by: Dragos Gheorghioiu dragosg@unikraft.com
…aging registries Signed-off-by: Alex-Andrei Cioc <andrei.cioc@unikraft.io>
nurof3n
force-pushed
the
nurof3n/chore/format-guides
branch
from
89d3bf6 to
bc7e600
Compare
craciunoiuc
approved these changes
Apr 1, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.