Skip to content

feat(examples & workflows): Draft PR for adding prometheus-3 example#330

Open
SerbaC6 wants to merge 2 commits into
unikraft-cloud:mainfrom
SerbaC6:serbanc/prometheus
Open

feat(examples & workflows): Draft PR for adding prometheus-3 example#330
SerbaC6 wants to merge 2 commits into
unikraft-cloud:mainfrom
SerbaC6:serbanc/prometheus

Conversation

@SerbaC6

@SerbaC6 SerbaC6 commented May 9, 2026

Copy link
Copy Markdown

No description provided.

@SerbaC6 SerbaC6 marked this pull request as ready for review May 9, 2026 09:41
@razvand razvand self-requested a review May 9, 2026 10:13

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the Kraftfile for your example? Add the version number in the directory name.

Use your proper name in the commit message. Use Serban Ciumacencu, not SerbaC6.

Use a single commit. A commit is a unit of contribution. It can't reference a pull request, it can't be something thought of as draft. A commit is NOT a history of your struggles. A commit is an atomic contribution. Think of that when you create a commit. See instructions here and use the model of commits in the commit history.

@SerbaC6 SerbaC6 force-pushed the serbanc/prometheus branch from 9e3a7db to f6c70e6 Compare May 9, 2026 19:23
SerbaC6 added 2 commits May 9, 2026 22:28
    Add a Prometheus 3.x example for Unikraft deployment based on Alpine Linux.

    The example includes:
    - Dockerfile: builds a minimal image using the Prometheus package pulled
      directly from the official Alpine Linux repositories
    - Kraftfile: defines the Unikraft deployment specification, including the
      runtime, erofs filesystem packaging, and startup command flags
    - prometheus.yml: provides the base scraping configuration, intervals,
      and static target definitions for the Prometheus instance
    - README.md: provides deployment instructions and configuration details

    The directory is explicitly named prometheus-3 rather than latest to
    track the current 3.x package provided by Alpine Linux, future-proofing
    the example against breaking changes in subsequent major releases.

    Signed-off-by: Serban Ciumacencu <serbaciumacencu@gmail.com>
    Introduce two GitHub Actions workflows to continuously test the
    prometheus-3 example against Unikraft Cloud environments.

    Workflows added:
    - example-prometheus-3-staging.yaml: targets the staging environment
    - example-prometheus-3-stable.yaml: targets the stable environment

    Each workflow is triggered on push and pull request to paths under
    prometheus-3/, as well as on a weekday schedule (Mon-Fri at 15:00 UTC).
    Both use kraftkit@staging to build and deploy the example via
    kraft cloud deploy, start the instance, assert the endpoint is
    reachable with curl, and unconditionally tear down the instance and
    image on completion.

    Signed-off-by: Serban Ciumacencu <serbaciumacencu@gmail.com>
@SerbaC6 SerbaC6 force-pushed the serbanc/prometheus branch from f6c70e6 to 5994f55 Compare May 9, 2026 19:30
@SerbaC6 SerbaC6 changed the title feat(examples): Draft PR for adding Prometheus example feat(examples & workflows): Draft PR for adding prometheus-3 example May 9, 2026
@SerbaC6 SerbaC6 requested a review from razvand May 16, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants