feat: Added MySQL example#380
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new MySQL example to the Unikraft Cloud examples repository, including packaging (Dockerfile + Kraftfile), a usage guide, and an end-to-end pytest that validates the deployment via a TLS-wrapped port mapping.
Changes:
- Add
mysql/example with a scratch-based rootfs and a startup wrapper that initializes and launchesmysqld. - Add
mysql/README.mdwith deployment and connectivity instructions (includingsocattunneling). - Add
mysql/test_mysql.pyend-to-end test and link the new example from the top-levelREADME.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds the MySQL example to the examples table. |
| mysql/Dockerfile | Builds a minimal scratch rootfs containing MySQL binaries/libs and the wrapper script. |
| mysql/Kraftfile | Declares runtime/rootfs and sets the command to the wrapper script. |
| mysql/README.md | Documents how to build, deploy, connect (via socat), and use volumes. |
| mysql/test_mysql.py | Adds an end-to-end test that deploys MySQL and runs basic SQL checks. |
| mysql/wrapper.sh | Initializes the datadir, generates init SQL, and starts mysqld. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+26
| echo "Starting MySQL process..." | ||
|
|
||
| exec /usr/sbin/mysqld --user=root --log-bin --init-file=/tmp/dynamic_init.sql |
dragosgheorghioiu
force-pushed
the
dragosg/feat/mysql-example
branch
5 times, most recently
from
48062f1 to
c16ab5d
Compare
nurof3n
requested changes
May 30, 2026
dragosgheorghioiu
force-pushed
the
dragosg/feat/mysql-example
branch
from
c16ab5d to
01863fd
Compare
nurof3n
approved these changes
Jun 10, 2026
nurof3n
left a comment
nurof3n
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
Approved-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
| COPY --from=build /lib/x86_64-linux-gnu/libpcre2-8.so.0 \ | ||
| /lib/x86_64-linux-gnu/libselinux.so.1 \ | ||
| /lib/x86_64-linux-gnu/libtinfo.so.6 \ | ||
| /lib/x86_64-linux-gnu/libacl.so.1 \ |
|
|
||
| # User database | ||
| COPY --from=build /etc/passwd /etc/passwd | ||
| COPY --from=build /etc/shadow /etc/shadow |
Contributor
There was a problem hiding this comment.
Spacing is inconsistent here
|
|
||
| **Using the legacy kraft CLI** | ||
| ```bash title="kraft" | ||
| kraft cloud deploy --scale-to-zero idle --scale-to-zero-cooldown 1s --scale-to-zero-stateful -p 443:8080/tls+http -M 1Gi . |
Contributor
There was a problem hiding this comment.
This command does not match the unikraft command
dragosgheorghioiu
force-pushed
the
dragosg/feat/mysql-example
branch
from
01863fd to
2a747ef
Compare
Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
dragosgheorghioiu
force-pushed
the
dragosg/feat/mysql-example
branch
from
2a747ef to
886b714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: FIELD-500