feat(tyk): Pass correct redis password at runtime#406
Merged
Conversation
Closes: FIELD-544 Signed-off-by: Daniel Vallance <daniel@unikraft.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Tyk + Redis example to supply the Redis password to the Tyk Gateway at runtime (via environment variable), aligning the deployment/test flow with Redis’ requirepass configuration.
Changes:
- Remove the static
storage.passwordentry fromtyk.confso the password is not baked into the image config. - Pass
TYK_GW_STORAGE_PASSWORDwhen launching the Tyk instance in the end-to-end test. - Update the README run/deploy commands to include
TYK_GW_STORAGE_PASSWORD.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tyk/tyk/rootfs/etc/tyk.conf | Removes the Redis password from the shipped Tyk config so it can be injected at runtime. |
| tyk/test_tyk.py | Adds runtime env injection (TYK_GW_STORAGE_PASSWORD) when starting the Tyk instance in the e2e test. |
| tyk/README.md | Updates manual run/deploy commands to include the runtime Redis password for Tyk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
113
to
115
| Build and deploy the Tyk instance: | ||
|
|
||
| **Using the unikraft CLI (Recommended)** |
nurof3n
approved these changes
Jun 9, 2026
nurof3n
left a comment
nurof3n
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
Approved-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
Contributor
|
??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: FIELD-544