Remove all markdownlint MD034 (bare access) violations in the codebase#531
Open
sizeru wants to merge 3 commits into
Open
Remove all markdownlint MD034 (bare access) violations in the codebase#531sizeru wants to merge 3 commits into
sizeru wants to merge 3 commits into
Conversation
Remove violations of MD034 markdownlint violation (bare links) where it is simple and unobtrusive to do so. This is in service of issue unikraft#381. Co-authored-by: Wyatt Borden <wyattborden@gmail.com> Signed-off-by: Nathan Williams <nathanwilliams@utexas.edu> Signed-off-by: Wyatt Borden <wyattborden@gmail.com>
JSX images cannot be cleanly escaped in angled brackets, so images must be surrounded by a disable comment and an enable comment to prevent MD034 (bare link) markdownlint errors. Co-authored-by: Wyatt Borden <wyattborden@gmail.com> Signed-off-by: Nathan Williams <nathanwilliams@utexas.edu> Signed-off-by: Wyatt Borden <wyattborden@gmail.com>
There are no more MD034 (bare access) violations in this repo, so it makes sense to re-enable the checks. Co-authored-by: Wyatt Borden <wyattborden@gmail.com> Signed-off-by: Nathan Williams <nathanwilliams@utexas.edu> Signed-off-by: Wyatt Borden <wyattborden@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in service of issue #381. MD034 violations were removed and MD034 checking was re-enabled in the markdownlint config file.