Skip to content

Fix Docker node_modules and search_meta shadowing #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericsandu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Docker node_modules and search_meta shadowing #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a0f93c
fix(docker): Update Dockerfile to prevent shadowing of search-meta
ericsandu May 3, 2026
a8a9a83
fix(docs): Update README.md docker instructions to prevent shadowing
ericsandu May 3, 2026
8a5c8df
fix(docker): Update Dockerfile to fix compilation on Alpine
ericsandu May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,26 @@ FROM node:20-alpine AS base
# Install dependencies only when needed
FROM base AS dev
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.

RUN apk add --no-cache libc6-compat
# libc6-compat & gcompat are needed for native modules (e.g. esbuild) on alpine.
# openssl is required for HTTPS requests (Octokit).
# git is required for husky, lint-staged, and metadata scripts.
RUN apk add --no-cache libc6-compat gcompat openssl git

WORKDIR /docs

ENV NODE_ENV=development
ENV NEXT_TELEMETRY_DISABLED=1

COPY . .
# Install dependencies separately to leverage Docker cache
COPY package.json package-lock.json ./
# Bypass postinstall since it requires source code which isn't copied yet
RUN npm pkg delete scripts.postinstall && npm install

RUN npm install
# Copy source code
COPY . .

CMD ["npm", "run", "dev"]
# Generate search-meta at runtime so it populates the mounted volume, then start dev
CMD ["sh", "-c", "npm run search-meta:gen && npm run dev"]

# Rebuild the source code only when needed
FROM dev AS builder
Expand All @@ -41,6 +48,7 @@ ENV NODE_ENV=production
ENV NEXT_TELEMETRY_DISABLED=1

RUN set -xe; \
apk add --no-cache openssl; \
addgroup --system --gid 1001 nodejs; \
adduser --system --uid 1001 nextjs

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ It is deployed on the [Unikraft website](https://unikraft.org/)
It provides information for the latest version of [Unikraft](https://github.com/unikraft/unikraft) and [KraftKit](https://kraftkit.sh).

Documentation is written in [MDX](https://mdxjs.com/) format.
Building and deploying it requires Node and NPM.
Building and deploying it requires Node and npm.
You can build and run either natively or using Docker.

## Building and Testing Natively
Expand All @@ -29,7 +29,7 @@ For local development:
```console
docker build -t ghcr.io/unikraft/docs:dev --target dev .

docker run -it --rm -v $(pwd):/docs -w /docs -p 3000:3000 ghcr.io/unikraft/docs:dev
docker run -it --rm -v $(pwd):/docs -v unikraft_modules:/docs/node_modules -w /docs -p 3000:3000 ghcr.io/unikraft/docs:dev
```

For production deployment:
Expand Down
Loading