Add MregCliLogger tests and fix logging configuration#423
Open
Add MregCliLogger tests and fix logging configuration#423
MregCliLogger tests and fix logging configuration#423Conversation
MregCliLogger testsMregCliLogger tests and fix logging configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some basic tests to ensure
MregCliLoggerbehaves like we expect it to.Forced logging reconfiguration
This PR also modifies
MregCliLogger.start_logging()to uselogging.basicConfig(..., force=true)to ensure the logger always re-runsbasicConfigif called multiple times. This fixes a bug discovered by these tests, which caused the logger to not switch log files when a different log file path was passed in. This affectedlogging startwhen using the-filenameoption.Docs for logging.basicConfig stating this behavior
Bug in action:
Since logging was already configured,
logging.basicConfigsilently skipped configuration, and thus did not create the new log file/tmp/mreg-cli.a3fp2t0p.360443/mreg-cli.log.2, causing an error whenlogging statusattempts to read it.