This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Open
Conversation
ec1edb3 to
1407278
Compare
1407278 to
32b58ab
Compare
Comment on lines
-93
to
+99
| def get_songs()->Iterator: | ||
| def get_songs() -> Iterator: | ||
| """ | ||
| Return songs that have the fingerprinted flag set TRUE (1). | ||
| """ | ||
| with session_withcommit() as session: | ||
| val = session.query(songs).all() | ||
| for row in val: | ||
| yield row | ||
| yield from val |
Author
There was a problem hiding this comment.
Function get_songs refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from)
| for chn in range(audiofile.channels): | ||
| channels.append(data[chn::audiofile.channels]) | ||
|
|
||
| channels = [data[chn::audiofile.channels] for chn in range(audiofile.channels)] |
Author
There was a problem hiding this comment.
Function read refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Author
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.09%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!