Conversation
Contributor
Author
|
Note: these tests are no longer using the correct values, still looking for feedback on the approach here |
Contributor
|
This seems like a legit approach to validating that the settings are generated as expected. so IMO this test is justified only for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to a casually slipped-in error that caused one of our settings not to validate to the correct values in OSE 1.8.0
I don't think I have the right approach here, but I couldn't figure out how to cycle through Config.OSE.apply_damage_options and check each key-value against the setting's choices. Suggestions encouraged!
I'll get to the other settings after that