Experimental#668
Open
Suterusu1337 wants to merge 38 commits into
Open
Conversation
…ed for the pair if it is already in progress.
Rollup for experimental
Rollup main into Experimental
universalconquistador
approved these changes
Jul 20, 2026
| FileCacheManager fileCacheManager, MareMediator mareMediator, PlayerPerformanceService playerPerformanceService, | ||
| ServerConfigurationManager serverConfigManager, ICompressedAlternateManager compressedAlternateManager, | ||
| PlayerPerformanceConfigService performanceConfig, MareConfigService mareConfigService, IDataManager dataManager) | ||
| PlayerPerformanceConfigService performanceConfig, MareConfigService mareConfigService, IDataManager dataManager, PlayerIdleStatusService playerIdleStatusService) |
There was a problem hiding this comment.
doesn't look like this is used
| return await _ipcManager.Heels.GetOffsetAsync().ConfigureAwait(false); | ||
|
|
||
| case PlayerChanges.Moodles: | ||
| var playerChara = await _dalamudUtil.GetPlayerCharacterAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
This is one of those synchronization issues I need to come through and fix up
| Logger.LogDebug("Attaching Census Data: {data}", dto); | ||
| } | ||
|
|
||
| _pairManager.InitialLoading = true; |
There was a problem hiding this comment.
could be called something like DeferRecreate or something?
| await Task.Delay(250, cts.Token).ConfigureAwait(false); | ||
| Logger.LogTrace("Waiting for permissions change for {data}", userData); | ||
| } | ||
| Mediator.Publish(new PairOfflineMessage(pair)); |
There was a problem hiding this comment.
Could you leave a comment here about how data won't get pushed on delayedframeworkupdate if it's too fast?
|
|
||
| // Adapted from https://stackoverflow.com/questions/1037595/c-sharp-detect-time-of-last-user-interaction-with-the-os | ||
|
|
||
| public static class IdleCheck |
There was a problem hiding this comment.
Reminder to revisit what to do with this
| public void ReceiveCharaData(OnlineUserCharaDataDto dto) | ||
| { | ||
| if (!_allClientPairs.TryGetValue(dto.User, out var pair)) throw new InvalidOperationException("No user found for " + dto.User); | ||
| _identToUserPairs.AddOrUpdate(dto.Ident, pair, (_, _) => pair); |
There was a problem hiding this comment.
if there's already a pair in _identToUserPairs, should we just use that one? should we dispose the old one? 🤔
| } | ||
| else | ||
| { | ||
| if (dto.AddonPlugin is not null) // process the dto via the addon plugin path if AddonPlugin exists |
| //var gate = GetActorLock(applicationBase.ToString()); | ||
| //await gate.WaitAsync(token).ConfigureAwait(false); | ||
|
|
||
| if (_penumbraCollection is null) |
| } | ||
| } | ||
|
|
||
| private async Task ApplyHonorificDataASync(CharacterData charaData) |
|
|
||
| private async Task ApplyLociDataASync(CharacterData charaData) | ||
| { | ||
| if (charaData.LociData is null) |
There was a problem hiding this comment.
please use == and != for null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.