fix(serialize): make key comparison locale-independent#178
Open
cernymatej wants to merge 2 commits intounjs:mainfrom
Open
fix(serialize): make key comparison locale-independent#178cernymatej wants to merge 2 commits intounjs:mainfrom
cernymatej wants to merge 2 commits intounjs:mainfrom
Conversation
cernymatej
changed the title
Author
|
@pi0 is there a reasony why |
cernymatej
force-pushed
the
fix/locale-independent-string-comparison
branch
from
c895083 to
0f949b2
Compare
cernymatej
commented
Feb 3, 2026
| map.set({ x: 42 }, "3"); | ||
|
|
||
| expect(serialize(map)).toMatchInlineSnapshot( | ||
| `"Map{{x:42}:'3',1:4,2:3,a:'1',z:2}"`, |
Author
There was a problem hiding this comment.
I think this snapshot was generated on a system with a different locale. The changes made in this PR should now ensure that the order is deterministic.
Collaborator
|
I have this also in #144 but purely for perf reasons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix nuxt/nuxt#34236
fix #177
This PR aims to solve a problem with the result of
serialize()being locale-dependent, which was introduced in #113.