Skip to content

Modify feedback#43

Merged
alexgarrettsmith merged 1 commit into
mainfrom
feedback-modify
Jul 8, 2026
Merged

Modify feedback#43
alexgarrettsmith merged 1 commit into
mainfrom
feedback-modify

Conversation

@alexgarrettsmith

Copy link
Copy Markdown
Collaborator

No description provided.

@alexgarrettsmith alexgarrettsmith merged commit 415c5c9 into main Jul 8, 2026
2 checks passed
@alexgarrettsmith alexgarrettsmith deleted the feedback-modify branch July 8, 2026 07:26
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No changes detected between origin/main and HEAD — nothing to triage.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

QA checklist — Edit and delete your own feedback

Before you start: You need two logged-in test accounts. Have account A submit a feedback item (or use one it already owns), and have a second feedback item owned by account B for the permission checks.

  • As account A (the author), open one of your own feedback items — you should see Edit and Delete actions near the "Submitted by…" line.
  • As account B, open a feedback item you did not submit — the Edit and Delete actions should be absent.
  • As account A, click Edit — you should land on an "Edit Feedback" form with the title and description already filled in with the item's current values.
  • Change the title and description and click Save Changes — you should be returned to the feedback item's page, see a "your feedback has been updated" confirmation, and see the new title/description reflected.
  • On the Edit form, clear the title (or the description) and click Save Changes — the form should stay put and show an inline validation error on the empty field; the item should not be changed.
  • On the Edit form, paste an overly long title (256+ characters) and save — you should see an inline error and no change saved.
  • As account A, open your feedback item and click Delete, then cancel the confirmation prompt — nothing should be deleted and you stay on the page.
  • Click Delete again and confirm the prompt — you should be taken to the dashboard with a "your feedback has been deleted" confirmation, and the item should no longer appear.
  • While logged in as account B, manually visit the edit URL for account A's feedback (e.g. /feedback/<id>/edit) — you should be blocked with a "forbidden" / 403 page rather than seeing the edit form.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Deployment
──────────
Required

  • Rebuild and deploy compiled frontend assets — the new Ideas/Edit.vue page and the edit/delete controls added to Ideas/Show.vue need a fresh npm run build, or they render blank/stale. (resources/js/Pages/Ideas/Edit.vue)

Operational
───────────
Verify

  • Confirm the new IdeaPolicy is picked up by Laravel policy auto-discovery so update/delete authorization actually enforces on the new destructive routes. (app/Policies/IdeaPolicy.php)
  • Confirm the new feedback.edit / feedback.update / feedback.destroy routes are live behind the auth middleware group after deploy. (routes/web.php)

alexgarrettsmith added a commit that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant