Skip to content

test issue#145

Closed
host6 wants to merge 1 commit into
untillpro:mainfrom
host6:test-issue-pr
Closed

test issue#145
host6 wants to merge 1 commit into
untillpro:mainfrom
host6:test-issue-pr

Conversation

@host6

@host6 host6 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

test issue

@host6 host6 closed this Jun 9, 2026
@host6
host6 deleted the test-issue-pr branch June 9, 2026 12:42
@augmentcode

augmentcode Bot commented Jun 9, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Introduces a precomputed repository context used by qs dev to reduce repeated git/GitHub CLI calls.

Changes:

  • Added gitcmds.RepoContext and gitcmds.LoadRepoContext to gather repo/org, branch info, upstream presence, uncommitted-change state, and parent repo (via gh api).
  • Refactored parent-repo lookup into getParentRepoByOrgRepo, keeping GetParentRepoName as a wrapper.
  • Updated internal/commands.Dev to use the new repo context and reduce redundant queries.
  • Handled git status porcelain code AD in changed-file parsing to avoid failing on that state.
  • Added a benchmark for git ls-remote in internal/commands.
  • Bumped Go toolchain version and updated several module dependencies.

Technical Notes: LoadRepoContext runs multiple local git checks concurrently, then performs a single GitHub API query once org/repo are known.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread gitcmds/context.go
ch <- result{setFn: func() { rc.HasUncommittedChanges = v }, err: err}
}()

for range numConcurrent {

@augmentcode augmentcode Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for range numConcurrent attempts to range over an int, which won’t compile in Go; as written, LoadRepoContext can’t build/run.

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

b.Helper()
out, err := exec.Command("git", "rev-parse", "--show-toplevel").Output()
require.NoError(b, err)
return string(out[:len(out)-1]) // trim trailing newline

@augmentcode augmentcode Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return string(out[:len(out)-1]) assumes the output always ends with exactly one \n; on Windows (\r\n) this can leave a trailing \r, and if the output ever lacks a newline it will drop the last character and return an invalid path.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant