Fix: Java JAR contains native library twice#430
Open
MarkReedZ wants to merge 1 commit intounum-cloud:main-devfrom
Open
Fix: Java JAR contains native library twice#430MarkReedZ wants to merge 1 commit intounum-cloud:main-devfrom
MarkReedZ wants to merge 1 commit intounum-cloud:main-devfrom
Conversation
Contributor
Author
|
Note that a cleaner fix for this issue would probably be to not copy the dlls and load them from In the build.gradle we copy |
Contributor
|
The latter sounds like a good plan. I can wait for that patch, if you want to follow up on this branch 🤗 |
4f5a74c to
d5ca036
Compare
Contributor
Author
|
Proper fix and verified the jar as in the OP. |
ashvardanian
reviewed
Jun 3, 2024
| System.loadLibrary("usearch"); // used for tests. This library in classpath only | ||
| } catch (UnsatisfiedLinkError e) { | ||
| try { | ||
| if (System.getProperty("os.name").equals("Mac OS X")) { |
Contributor
There was a problem hiding this comment.
Do we know what this property is equal to on Windows? We should probably link to .dll there.
ashvardanian
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #314 by excluding the shared/ directory.
Tested with