Skip to content

Updated to Crossplane V2#250

Merged
jahabibi merged 10 commits intoupbound:mainfrom
jahabibi:v2-migration
Mar 12, 2026
Merged

Updated to Crossplane V2#250
jahabibi merged 10 commits intoupbound:mainfrom
jahabibi:v2-migration

Conversation

@jahabibi
Copy link
Contributor

@jahabibi jahabibi commented Feb 6, 2026

Description of your changes

Migration of Crossplane v1 cluster scoped to Crossplane v2 namespace scoped resources.

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested


up test run tests/* 

✓ Parsing tests
✓ Collecting resources
✓ Generating language schemas
✓ Checking dependencies
✓ Building functions
✓ Building configuration package
✓ Pushing embedded functions to local daemon
✓ Assert test-cluster
🙌
🙌 Tests Summary:
🙌 ------------------
🙌 Total Tests Executed: 1
🙌 Passed tests:         1
🙌 Failed tests:         0

@Upbound-CLA
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jahabibi jahabibi marked this pull request as ready for review March 3, 2026 17:52
@jahabibi jahabibi requested review from kaessert and ytsarev March 3, 2026 17:52
@jahabibi jahabibi requested a review from kaessert March 4, 2026 16:42
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor issues, left the comments inline

Please extend How has this code been tested section of the PR, thanks!

@jaymiracola
Copy link

jaymiracola commented Mar 5, 2026

Looks like configuration-aws-eks expects kubernetesVersion and so no k8s version is being set. Getting AWS default of 1.35

Update - Its not here, there is a conflict in configuration-aws-eks that needs fixed, bumped, and added to here.
https://github.com/upbound/configuration-aws-eks/blob/main/functions/eks/main.k#L96 should be ..

    eksv1beta1.Cluster {
        metadata = _metadata("kubernetesCluster")
        spec: _defaults | {
            forProvider = {
                region = params.region
                version = params.version

@jahabibi jahabibi requested a review from ytsarev March 5, 2026 23:48
@jahabibi jahabibi merged commit be065e6 into upbound:main Mar 12, 2026
3 checks passed
@jahabibi jahabibi deleted the v2-migration branch March 12, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants