fix(kcl): avoid full OXR cast to prevent conditions type error#176
Open
fix(kcl): avoid full OXR cast to prevent conditions type error#176
Conversation
The auto-generated KCL model types status.conditions as a typed list (e.g. [ClusterStatusConditionsItems0]) which is incompatible with the generic list that Crossplane passes at runtime. This causes a fatal EvaluationError on every reconciliation after the first (once Crossplane populates the XR status conditions). Fix by keeping the raw OXR dict and casting only spec.parameters to the typed schema, following the pattern used in configuration-azure-aks. This preserves type safety for parameter access while avoiding the conditions type mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxrand cast onlyspec.parametersto the typed modelEvaluationErroronstatus.conditionswhere the auto-generated KCL model expects a typed list but Crossplane passes a generic list at runtimeDetails
The auto-generated KCL model types
status.conditionsas[SpecificConditionType], but Crossplane populates it as a generic JSON list at runtime. Full OXR casting (oxr = Type{**option("params").oxr}) includes this field, causing:The fix follows the proven pattern from configuration-azure-aks v0.16.0:
Test plan
up project buildsucceeds