Skip to content

Set up shared Prettier config from @upfluence/w-conf#13

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/setup-prettier-config
Draft

Set up shared Prettier config from @upfluence/w-conf#13
Copilot wants to merge 2 commits into
mainfrom
copilot/setup-prettier-config

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 5, 2026

What does this PR do?

Migrates from a standalone .prettierrc.js to the shared @upfluence/w-conf Prettier configuration, following the same pattern already used in upfluence/hyperstream.

  • Removed .prettierrc.js (CJS config)
  • Added prettier.config.mjs (ESM, uses buildConfiguration from @upfluence/w-conf/prettier with import sorting scoped to @upfluence/ember-brand-manager)
  • Updated package.json devDependencies: added @upfluence/w-conf ^0.2.0, @trivago/prettier-plugin-sort-imports ^4.3.0, bumped prettier to ^3.0.0
  • Reformatted all affected source files via prettier --write . — primarily import ordering and trailing comma removal
// prettier.config.mjs
import { buildConfiguration } from '@upfluence/w-conf/prettier';

export default buildConfiguration({
  sortImport: {
    packages: ['@upfluence/ember-brand-manager']
  }
});

What are the observable changes?

Imports in JS/TS files are now sorted (@ember/*, @glimmer/* → third-party → @upfluence/ember-brand-manager/* → relative). Trailing commas removed from multi-line expressions. .hbs files use double quotes.

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/orgs/upfluence/packages/npm/w-conf/versions
    • Triggering command: /usr/bin/curl curl -s -H Authorization: ****** REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Summary

Set up the shared Prettier configuration from @upfluence/w-conf for this repository, following the same pattern as done in upfluence/identity-web#787 and already present in upfluence/hyperstream.

Changes required

1. Remove .prettierrc.js

Delete the existing .prettierrc.js file at the root of the repository.

2. Add prettier.config.mjs

Create a new file prettier.config.mjs at the root of the repository with the following content:

import { buildConfiguration } from '@upfluence/w-conf/prettier';

export default buildConfiguration({
  sortImport: {
    packages: ['@upfluence/ember-brand-manager']
  }
});

The package name @upfluence/ember-brand-manager comes from the "name" field in package.json.

3. Update package.json devDependencies

Add the following packages to devDependencies in package.json (they are not currently present):

  • "@upfluence/w-conf": "^0.2.0"
  • "@trivago/prettier-plugin-sort-imports": "^4.3.0"
  • "prettier": "^3.0.0"

4. Run pnpm prettier --write

After adding the config file and installing dependencies, run:

pnpm prettier --write .

Commit all files reformatted by Prettier as part of this PR.

Notes

  • The config file must use ESM syntax (import/export default) — do NOT use require/module.exports
  • The file must be named prettier.config.mjs (not .prettierrc.js or prettier.config.js)
  • The old .prettierrc.js must be deleted

This pull request was created from Copilot chat.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: phndiaye <4022350+phndiaye@users.noreply.github.com>
Copilot AI changed the title [WIP] Set up shared Prettier configuration for the repository Set up shared Prettier config from @upfluence/w-conf Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants